espressif/binutils-gdb
1
0
Fork 0
mirror of https://github.com/espressif/binutils-gdb.git synced 2025-06-27 14:39:09 +08:00
Code Issues Packages Projects Releases Wiki Activity

Rename tui_data_item_window::item_no

Browse Source 
tui_data_item_window::item_no is misnamed -- it only can be used for a
register, but it references a "display" number as well.  (Based on
other comments I've seen in the past -- most since deleted -- I think
there were plans at one point to display variables in this window as
well.  However, this was never implemented.)

This patch renames this member to be more correct.

gdb/ChangeLog
2020-07-01  Tom Tromey  <tom@tromey.com>

	* tui/tui-regs.c (tui_data_window::show_register_group)
	(tui_data_window::check_register_values): Update.
	* tui/tui-regs.h (struct tui_data_item_window) <regno>: Rename
	from item_no.
This commit is contained in:
Tom Tromey
2020-07-01 21:21:12 -06:00
parent c9753adb01
commit 22b7b0412b
3 changed files with 11 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
gdb/ChangeLog
View File

@ -1,3 +1,10 @@
2020-07-01 Tom Tromey <tom@tromey.com>
* tui/tui-regs.c (tui_data_window::show_register_group)
(tui_data_window::check_register_values): Update.
* tui/tui-regs.h (struct tui_data_item_window) <regno>: Rename
from item_no.
2020-07-01 Tom Tromey <tom@tromey.com> 2020-07-01 Tom Tromey <tom@tromey.com>
* tui/tui-regs.c (tui_data_window::show_register_group): Remove * tui/tui-regs.c (tui_data_window::show_register_group): Remove

4
gdb/tui/tui-regs.c
View File

@ -259,7 +259,7 @@ tui_data_window::show_register_group (struct reggroup *group,
data_item_win = &m_regs_content[pos]; data_item_win = &m_regs_content[pos];
if (!refresh_values_only) if (!refresh_values_only)
{ {
data_item_win->item_no = regnum; data_item_win->regno = regnum;
data_item_win->highlight = false; data_item_win->highlight = false;
} }
tui_get_register (frame, data_item_win, regnum, 0); tui_get_register (frame, data_item_win, regnum, 0);
@ -486,7 +486,7 @@ tui_data_window::check_register_values (struct frame_info *frame)
was_hilighted = data_item_win.highlight; was_hilighted = data_item_win.highlight;
tui_get_register (frame, &data_item_win, tui_get_register (frame, &data_item_win,
data_item_win.item_no, data_item_win.regno,
&data_item_win.highlight); &data_item_win.highlight);
if (data_item_win.highlight || was_hilighted) if (data_item_win.highlight || was_hilighted)

4
gdb/tui/tui-regs.h
View File

@ -48,8 +48,8 @@ struct tui_data_item_window : public tui_gen_win_info
return 1; return 1;
} }
/* The register number, or data display number. */ /* The register number. */
int item_no = -1; int regno = -1;
bool highlight = false; bool highlight = false;
std::string content; std::string content;
}; };