espressif/binutils-gdb
1
0
Fork 0
mirror of https://github.com/espressif/binutils-gdb.git synced 2025-06-28 07:08:01 +08:00
Code Issues Packages Projects Releases Wiki Activity

gdb/

Browse Source 
Fix double free on error inserting the breakpoint instruction.
	* breakpoint.c (create_breakpoints): Move the
	update_global_location_list call to ...
	(break_command_really): ... here together with the second local call
	both unified after all the cleanups.
This commit is contained in:
Jan Kratochvil
2009-04-23 22:38:24 +00:00
parent b14b1491f2
commit 217dc9e25b
2 changed files with 11 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
gdb/ChangeLog
View File

@ -1,3 +1,11 @@
2009-04-23 Jan Kratochvil <jan.kratochvil@redhat.com>
Fix double free on error inserting the breakpoint instruction.
* breakpoint.c (create_breakpoints): Move the
update_global_location_list call to ...
(break_command_really): ... here together with the second local call
both unified after all the cleanups.
2009-04-23 Sergio Durigan Junior <sergiodj@linux.vnet.ibm.com> 2009-04-23 Sergio Durigan Junior <sergiodj@linux.vnet.ibm.com>
Tom Tromey <tromey@redhat.com> Tom Tromey <tromey@redhat.com>

6
gdb/breakpoint.c
View File

@ -5458,8 +5458,6 @@ create_breakpoints (struct symtabs_and_lines sals, char **addr_string,
cond_string, type, disposition, cond_string, type, disposition,
thread, task, ignore_count, ops, from_tty, enabled); thread, task, ignore_count, ops, from_tty, enabled);
} }
update_global_location_list (1);
} }
/* Parse ARG which is assumed to be a SAL specification possibly /* Parse ARG which is assumed to be a SAL specification possibly
@ -5800,7 +5798,6 @@ break_command_really (char *arg, char *cond_string, int thread,
b->ops = ops; b->ops = ops;
b->enable_state = enabled ? bp_enabled : bp_disabled; b->enable_state = enabled ? bp_enabled : bp_disabled;
update_global_location_list (1);
mention (b); mention (b);
} }
@ -5812,6 +5809,9 @@ break_command_really (char *arg, char *cond_string, int thread,
discard_cleanups (breakpoint_chain); discard_cleanups (breakpoint_chain);
/* But cleanup everything else. */ /* But cleanup everything else. */
do_cleanups (old_chain); do_cleanups (old_chain);
/* error call may happen here - have BREAKPOINT_CHAIN already discarded. */
update_global_location_list (1);
} }
/* Set a breakpoint. /* Set a breakpoint.