espressif/binutils-gdb
1
0
Fork 0
mirror of https://github.com/espressif/binutils-gdb.git synced 2025-08-06 14:49:38 +08:00
Code Issues Packages Projects Releases Wiki Activity

Respect supportsMemoryReferences in DAP

Browse Source 
I noticed that the support for memoryReference in the "variables"
output is gated on the client "supportsMemoryReferences" capability.

This patch implements this and makes some other changes to the DAP
memory reference code:

* Remove the memoryReference special case from _SetResult.
  Upstream DAP fixed this oversight in response to
  https://github.com/microsoft/debug-adapter-protocol/issues/414

* Don't use the address of a variable as its memoryReference -- only
  emit this for pointer types.  There's no spec support for the
  previous approach.

* Use strip_typedefs to handle typedefs of pointers.
This commit is contained in:
Tom Tromey
2023-07-27 13:06:38 -06:00
parent af93035b27
commit 2128d888b8
5 changed files with 13 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
gdb/python/lib/gdb/dap/evaluate.py
View File

@ -55,13 +55,6 @@ class _SetResult(VariableReference):
def __init__(self, value):
super().__init__(None, value, "value")
def to_object(self):
result = super().to_object()
# This is not specified in the setExpression result.
if "memoryReference" in result:
del result["memoryReference"]
return result
# Helper function to perform an assignment.
@in_gdb_thread

11
gdb/python/lib/gdb/dap/varref.py
View File

@ -162,10 +162,13 @@ class VariableReference(BaseReference):
result["indexedVariables"] = num_children
else:
result["namedVariables"] = num_children
if self.value.type.code == gdb.TYPE_CODE_PTR:
result["memoryReference"] = hex(int(self.value))
elif self.value.address is not None:
result["memoryReference"] = hex(int(self.value.address))
if client_bool_capability("supportsMemoryReferences"):
# https://github.com/microsoft/debug-adapter-protocol/issues/414
# changed DAP to allow memory references for any of the
# variable response requests, and to lift the restriction
# to pointer-to-function from Variable.
if self.value.type.strip_typedefs().code == gdb.TYPE_CODE_PTR:
result["memoryReference"] = hex(int(self.value))
if client_bool_capability("supportsVariableType"):
result["type"] = str(self.value.type)
return result