espressif/binutils-gdb
1
0
Fork 0
mirror of https://github.com/espressif/binutils-gdb.git synced 2025-06-21 02:24:17 +08:00
Code Issues Packages Projects Releases Wiki Activity

x86: drop SSE4a from SSE check again

Browse Source 
Upon re-consideration in commit 569d50f1c611 ("x86: further refine SSE
check (SSE4a, SHA, GFNI)") I went too far: Mixing of SSE and AVX insns
doesn't suffer as bad a penalty on AMD CPUs as on Intel ones. SSE4a
being an AMD-only extension, it shouldn't be part of the ISA extensions
set for which the diagnostic may get issued. Undo that part.
This commit is contained in:
Jan Beulich
2020-06-16 10:34:55 +02:00
parent a435742a7f
commit 2106ed9baf
6 changed files with 15 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
gas/ChangeLog
View File

@ -1,3 +1,13 @@
2020-06-16 Jan Beulich <jbeulich@suse.com>
* config/tc-i386.c (md_assemble): Drop SSE4a from SSE check
conditional.
* testsuite/gas/i386/sse-check.s: Adjust comment.
* testsuite/gas/i386/sse-check-error.l,
testsuite/gas/i386/sse-check-warn.e,
testsuite/gas/i386/x86-64-sse-check-error.l: Adjust
expectations.
2020-06-16 Alan Modra <amodra@gmail.com> 2020-06-16 Alan Modra <amodra@gmail.com>
* config/tc-tic30.h: Remove OBJ_AOUT support. * config/tc-tic30.h: Remove OBJ_AOUT support.

1
gas/config/tc-i386.c
View File

@ -4753,7 +4753,6 @@ md_assemble (char *line)
|| i.tm.cpu_flags.bitfield.cpussse3 || i.tm.cpu_flags.bitfield.cpussse3
|| i.tm.cpu_flags.bitfield.cpusse4_1 || i.tm.cpu_flags.bitfield.cpusse4_1
|| i.tm.cpu_flags.bitfield.cpusse4_2 || i.tm.cpu_flags.bitfield.cpusse4_2
|| i.tm.cpu_flags.bitfield.cpusse4a
|| i.tm.cpu_flags.bitfield.cpupclmul || i.tm.cpu_flags.bitfield.cpupclmul
|| i.tm.cpu_flags.bitfield.cpuaes || i.tm.cpu_flags.bitfield.cpuaes
|| i.tm.cpu_flags.bitfield.cpusha || i.tm.cpu_flags.bitfield.cpusha

6
gas/testsuite/gas/i386/sse-check-error.l
View File

@ -5,7 +5,6 @@
.*:16: Error: .* .*:16: Error: .*
.*:19: Error: .* .*:19: Error: .*
.*:20: Error: .* .*:20: Error: .*
.*:23: Error: .*
.*:26: Error: .* .*:26: Error: .*
.*:29: Error: .* .*:29: Error: .*
.*:32: Error: .* .*:32: Error: .*
@ -44,9 +43,8 @@ GAS LISTING .*
.* Error: SSE instruction `pcmpgtq' is used .* Error: SSE instruction `pcmpgtq' is used
[ ]*20[ ]+C1 [ ]*20[ ]+C1
[ ]*21[ ]+ [ ]*21[ ]+
[ ]*22[ ]+\# SSE4a instruction [ ]*22[ ]+\# SSE4a instruction.*
[ ]*23[ ]+\?\?\?\? 660F78C0 extrq \$0, \$0, %xmm0 [ ]*23[ ]+\?\?\?\? 660F78C0 extrq \$0, \$0, %xmm0
.* Error: SSE instruction `extrq' is used
[ ]*23[ ]+0000 [ ]*23[ ]+0000
[ ]*24[ ]+ [ ]*24[ ]+
[ ]*25[ ]+\# PCMUL instruction [ ]*25[ ]+\# PCMUL instruction
@ -70,7 +68,7 @@ GAS LISTING .*
[ ]*36[ ]+\?\?\?\? 62F27D09 vgf2p8mulb %xmm0, %xmm0, %xmm0\{%k1\} [ ]*36[ ]+\?\?\?\? 62F27D09 vgf2p8mulb %xmm0, %xmm0, %xmm0\{%k1\}
[ ]*36[ ]+CFC0 [ ]*36[ ]+CFC0
[ ]*37[ ]+\?\?\?\? 62F27D48 vgf2p8mulb %zmm0, %zmm0, %zmm0 [ ]*37[ ]+\?\?\?\? 62F27D48 vgf2p8mulb %zmm0, %zmm0, %zmm0
[ ]*37[ ]+CFC0
GAS LISTING .* GAS LISTING .*
[ ]*37[ ]+CFC0

1
gas/testsuite/gas/i386/sse-check-warn.e
View File

@ -5,7 +5,6 @@
.*:16: Warning: SSE instruction `phaddw' is used .*:16: Warning: SSE instruction `phaddw' is used
.*:19: Warning: SSE instruction `blendvpd' is used .*:19: Warning: SSE instruction `blendvpd' is used
.*:20: Warning: SSE instruction `pcmpgtq' is used .*:20: Warning: SSE instruction `pcmpgtq' is used
.*:23: Warning: SSE instruction `extrq' is used
.*:26: Warning: SSE instruction `pclmulqdq' is used .*:26: Warning: SSE instruction `pclmulqdq' is used
.*:29: Warning: SSE instruction `aesdec' is used .*:29: Warning: SSE instruction `aesdec' is used
.*:32: Warning: SSE instruction `sha1nexte' is used .*:32: Warning: SSE instruction `sha1nexte' is used

2
gas/testsuite/gas/i386/sse-check.s
View File

@ -19,7 +19,7 @@ _start:
blendvpd %xmm0,%xmm1,%xmm0 blendvpd %xmm0,%xmm1,%xmm0
pcmpgtq %xmm1,%xmm0 pcmpgtq %xmm1,%xmm0
# SSE4a instruction # SSE4a instruction (no diagnostic)
extrq $0, $0, %xmm0 extrq $0, $0, %xmm0
# PCMUL instruction # PCMUL instruction

6
gas/testsuite/gas/i386/x86-64-sse-check-error.l
View File

@ -5,7 +5,6 @@
.*:16: Error: .* .*:16: Error: .*
.*:19: Error: .* .*:19: Error: .*
.*:20: Error: .* .*:20: Error: .*
.*:23: Error: .*
.*:26: Error: .* .*:26: Error: .*
.*:29: Error: .* .*:29: Error: .*
.*:32: Error: .* .*:32: Error: .*
@ -44,9 +43,8 @@ GAS LISTING .*
.* Error: SSE instruction `pcmpgtq' is used .* Error: SSE instruction `pcmpgtq' is used
[ ]*20[ ]+C1 [ ]*20[ ]+C1
[ ]*21[ ]+ [ ]*21[ ]+
[ ]*22[ ]+\# SSE4a instruction [ ]*22[ ]+\# SSE4a instruction.*
[ ]*23[ ]+\?\?\?\? 660F78C0 extrq \$0, \$0, %xmm0 [ ]*23[ ]+\?\?\?\? 660F78C0 extrq \$0, \$0, %xmm0
.* Error: SSE instruction `extrq' is used
[ ]*23[ ]+0000 [ ]*23[ ]+0000
[ ]*24[ ]+ [ ]*24[ ]+
[ ]*25[ ]+\# PCMUL instruction [ ]*25[ ]+\# PCMUL instruction
@ -70,7 +68,7 @@ GAS LISTING .*
[ ]*36[ ]+\?\?\?\? 62F27D09 vgf2p8mulb %xmm0, %xmm0, %xmm0\{%k1\} [ ]*36[ ]+\?\?\?\? 62F27D09 vgf2p8mulb %xmm0, %xmm0, %xmm0\{%k1\}
[ ]*36[ ]+CFC0 [ ]*36[ ]+CFC0
[ ]*37[ ]+\?\?\?\? 62F27D48 vgf2p8mulb %zmm0, %zmm0, %zmm0 [ ]*37[ ]+\?\?\?\? 62F27D48 vgf2p8mulb %zmm0, %zmm0, %zmm0
[ ]*37[ ]+CFC0
GAS LISTING .* GAS LISTING .*
[ ]*37[ ]+CFC0