diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog index 10683db566d..ecccb613045 100644 --- a/gdb/testsuite/ChangeLog +++ b/gdb/testsuite/ChangeLog @@ -1,3 +1,10 @@ +2020-04-24 Tom de Vries + + * lib/gdb.exp (default_gdb_start): Handle eof. + (clean_restart): Detect and handle gdb_start failure. Return -1 upon + failure. + * gdb.base/readnever.exp: Handle clean_restart failure. + 2020-04-23 Tom de Vries * gdb.base/decl-before-def.exp: Run to main and print a again. diff --git a/gdb/testsuite/gdb.base/readnever.exp b/gdb/testsuite/gdb.base/readnever.exp index ab2e18e2260..113176c1789 100644 --- a/gdb/testsuite/gdb.base/readnever.exp +++ b/gdb/testsuite/gdb.base/readnever.exp @@ -29,7 +29,9 @@ if { [lsearch -exact $GDBFLAGS -readnow] != -1 \ save_vars { GDBFLAGS } { append GDBFLAGS " --readnever" - clean_restart ${binfile} + if { [clean_restart ${binfile}] == -1 } { + return -1 + } } if ![runto_main] then { diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp index 8418c3d8753..cdf96e3c703 100644 --- a/gdb/testsuite/lib/gdb.exp +++ b/gdb/testsuite/lib/gdb.exp @@ -1894,6 +1894,11 @@ proc default_gdb_start { } { unset gdb_spawn_id return -1 } + eof { + perror "(eof) GDB never initialized." + unset gdb_spawn_id + return -1 + } } # force the height to "unlimited", so no pagers get used @@ -6097,24 +6102,40 @@ proc build_executable { testname executable {sources ""} {options {debug}} } { # Starts fresh GDB binary and loads an optional executable into GDB. # Usage: clean_restart [executable] # EXECUTABLE is the basename of the binary. +# Return -1 if starting gdb or loading the executable failed. proc clean_restart { args } { global srcdir global subdir + global errcnt if { [llength $args] > 1 } { error "bad number of args: [llength $args]" } gdb_exit + + # We'd like to do: + # if { [gdb_start] == -1 } { + # return -1 + # } + # but gdb_start is a ${tool}_start proc, which doesn't have a defined + # return value. So instead, we test for errcnt. + set saved_errcnt $errcnt gdb_start + if { $errcnt > $saved_errcnt } { + return -1 + } + gdb_reinitialize_dir $srcdir/$subdir if { [llength $args] >= 1 } { set executable [lindex $args 0] set binfile [standard_output_file ${executable}] - gdb_load ${binfile} + return [gdb_load ${binfile}] } + + return 0 } # Prepares for testing by calling build_executable_full, then