espressif/binutils-gdb
1
0
Fork 0
mirror of https://github.com/espressif/binutils-gdb.git synced 2025-10-13 02:45:02 +08:00
Code Issues Packages Projects Releases Wiki Activity

Re: gas: add visibility support using GNU syntax on XCOFF

Browse Source 
tc-ppc.c: In function 'ppc_comm':
tc-ppc.c:4560:40: error: 'visibility' may be used uninitialized in this function [-Werror=maybe-uninitialized]

With that fixed we hit lots of segfaults in the ld testsuite.

	PR 22085
bfd/
	* xcofflink.c (xcoff_link_input_bfd): Don't segfault on NULL
	sym_hash.
gas/
	* config/tc-ppc.c (ppc_comm): Init visibility.
This commit is contained in:
Alan Modra
2022-01-13 15:42:13 +10:30
parent c39828d4c9
commit 1ffce3f87d
2 changed files with 6 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
bfd/xcofflink.c
View File

@ -4615,8 +4615,11 @@ xcoff_link_input_bfd (struct xcoff_final_link_info *flinfo,
}
/* Update visibility. */
isym.n_type &= ~SYM_V_MASK;
isym.n_type |= (*sym_hash)->visibility;
if (*sym_hash)
{
isym.n_type &= ~SYM_V_MASK;
isym.n_type |= (*sym_hash)->visibility;
}
/* Output the symbol. */
bfd_coff_swap_sym_out (output_bfd, (void *) &isym, (void *) outsym);

2
gas/config/tc-ppc.c
View File

@ -4380,7 +4380,7 @@ ppc_comm (int lcomm)
symbolS *lcomm_sym = NULL;
symbolS *sym;
char *pfrag;
unsigned short visibility;
unsigned short visibility = 0;
struct ppc_xcoff_section *section;
endc = get_symbol_name (&name);