espressif/binutils-gdb
1
0
Fork 0
mirror of https://github.com/espressif/binutils-gdb.git synced 2025-05-31 10:09:16 +08:00
Code Issues Packages Projects Releases Wiki Activity

Warn if /proc is not accessible

Browse Source 
There's a buildroot where I want to debug a binary, and I tried to
connect to it from outside, but got very weird errors like
architecture mismatch or protocol errors.  At last, after switching on
'--debug' for gdbserver I found a message 'Can't open /proc/pid/'
message and suddenly found that I forgot to mount procfs in my
buildroot.

Make discovering the problem easier by making GDB / GDBserver warn
(even without --debug) if /proc can not be accessed.

Native debugging:

 (gdb) start
 Temporary breakpoint 1 at 0x400835: file test.c, line 10.
 Starting program: /tmp/test
 warning: /proc is not accessible.

GDBserver/remote debugging:

 $ ./gdbserver :9999 ./gdbserver
 gdbserver: /proc is not accessible.

gdb/ChangeLog:
2018-07-04  Vyacheslav Barinov  <v.barinov@samsung.com>
	    Pedro Alves  <palves@redhat.com>

	* linux-nat.c (linux_init_ptrace): Rename to ...
	(linux_init_ptrace_procfs): ... this.  Call
	linux_proc_init_warnings.
	(linux_nat_target::post_attach)
	(linux_nat_target::post_startup_inferior): Adjust.
	* nat/linux-procfs.c (linux_proc_init_warnings): Define function.
	* nat/linux-procfs.h (linux_proc_init_warnings): Declare function.

gdb/gdbserver/ChangeLog:
2018-07-04  Vyacheslav Barinov  <v.barinov@samsung.com>
	    Pedro Alves  <palves@redhat.com>

	* linux-low.c (initialize_low): Call linux_proc_init_warnings.
This commit is contained in:
Vyacheslav Barinov
2018-07-04 16:13:29 +01:00
committed by Pedro Alves
parent 94d401b8b8
commit 1b919490e8
6 changed files with 45 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
gdb/linux-nat.c
View File

@ -384,18 +384,19 @@ linux_nat_ptrace_options (int attached)
return options;
}
/* Initialize ptrace warnings and check for supported ptrace
features given PID.
/* Initialize ptrace and procfs warnings and check for supported
ptrace features given PID.
ATTACHED should be nonzero iff we attached to the inferior. */
static void
linux_init_ptrace (pid_t pid, int attached)
linux_init_ptrace_procfs (pid_t pid, int attached)
{
int options = linux_nat_ptrace_options (attached);
linux_enable_event_reporting (pid, options);
linux_ptrace_init_warnings ();
linux_proc_init_warnings ();
}
linux_nat_target::~linux_nat_target ()
@ -404,13 +405,13 @@ linux_nat_target::~linux_nat_target ()
void
linux_nat_target::post_attach (int pid)
{
linux_init_ptrace (pid, 1);
linux_init_ptrace_procfs (pid, 1);
}
void
linux_nat_target::post_startup_inferior (ptid_t ptid)
{
linux_init_ptrace (ptid.pid (), 0);
linux_init_ptrace_procfs (ptid.pid (), 0);
}
/* Return the number of known LWPs in the tgid given by PID. */