espressif/binutils-gdb
1
0
Fork 0
mirror of https://github.com/espressif/binutils-gdb.git synced 2025-06-24 12:23:31 +08:00
Code Issues Packages Projects Releases Wiki Activity

Add add_internal_function overload

Browse Source 
add_internal_function sets a command destroyer that frees the doc
string.  However, many callers do not pass in an allocated doc string.

This adds a new overload to clearly differentiate the two cases,
fixing the latent bug.

gdb/ChangeLog
2019-11-26  Tom Tromey  <tom@tromey.com>

	* value.h (add_internal_function): Add new overload.  Move
	documentation from value.h.
	* value.c (do_add_internal_function): New function.
	(add_internal_function): Use it.  Add new overload.
	(function_destroyer): Don't free doc.
	* python/py-function.c (fnpy_init): Update.

Change-Id: I3f6df925bc6b3e1bccbad9eeebc487b908bb5a2a
This commit is contained in:
Tom Tromey
2019-11-15 16:49:17 -07:00
parent 8318f3c337
commit 1a6d41c643
4 changed files with 54 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
gdb/value.h
View File

@ -1165,9 +1165,22 @@ typedef struct value *(*internal_function_fn) (struct gdbarch *gdbarch,
int argc,
struct value **argv);
void add_internal_function (const char *name, const char *doc,
internal_function_fn handler,
void *cookie);
/* Add a new internal function. NAME is the name of the function; DOC
is a documentation string describing the function. HANDLER is
called when the function is invoked. COOKIE is an arbitrary
pointer which is passed to HANDLER and is intended for "user
data". */
extern void add_internal_function (const char *name, const char *doc,
internal_function_fn handler,
void *cookie);
/* This overload takes an allocated documentation string. */
extern void add_internal_function (const char *name,
gdb::unique_xmalloc_ptr<char> &&doc,
internal_function_fn handler,
void *cookie);
struct value *call_internal_function (struct gdbarch *gdbarch,
const struct language_defn *language,