espressif/binutils-gdb
1
0
Fork 0
mirror of https://github.com/espressif/binutils-gdb.git synced 2025-09-12 17:47:18 +08:00
Code Issues Packages Projects Releases Wiki Activity

Remove tui_data_window::display_all_data

Browse Source 
tui_data_window::rerender clears the data item windows, and then calls
display_all_data.  However, that method only does anything if the
contents are not empty.  So, display_all_data can be renamed and the
wrapper removed.

gdb/ChangeLog
2019-08-30  Tom Tromey  <tom@tromey.com>

	* tui/tui-regs.h (struct tui_data_window) <display_all_data>:
	Don't declare.
	* tui/tui-regs.c (tui_data_window::show_registers): Call
	rerender.
	(tui_data_window::rerender): Rename from display_all_data.
	(tui_data_window::rerender): Remove old implementation.
This commit is contained in:
Tom Tromey
2019-07-14 08:27:34 -06:00
parent 1f6d2f100a
commit 18bb55c722
3 changed files with 11 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
gdb/ChangeLog
View File

@ -1,3 +1,12 @@
2019-08-30 Tom Tromey <tom@tromey.com>
* tui/tui-regs.h (struct tui_data_window) <display_all_data>:
Don't declare.
* tui/tui-regs.c (tui_data_window::show_registers): Call
rerender.
(tui_data_window::rerender): Rename from display_all_data.
(tui_data_window::rerender): Remove old implementation.
2019-08-30 Tom Tromey <tom@tromey.com> 2019-08-30 Tom Tromey <tom@tromey.com>
* tui/tui-regs.c (tui_data_window::display_all_data): Change * tui/tui-regs.c (tui_data_window::display_all_data): Change

18
gdb/tui/tui-regs.c
View File

@ -161,7 +161,7 @@ tui_data_window::show_registers (struct reggroup *group)
for (auto &&data_item_win : regs_content) for (auto &&data_item_win : regs_content)
data_item_win.highlight = false; data_item_win.highlight = false;
current_group = group; current_group = group;
display_all_data (); rerender ();
} }
else else
{ {
@ -434,7 +434,7 @@ tui_data_window::erase_data_content (const char *prompt)
/* See tui-regs.h. */ /* See tui-regs.h. */
void void
tui_data_window::display_all_data () tui_data_window::rerender ()
{ {
if (regs_content.empty ()) if (regs_content.empty ())
erase_data_content (_("[ Register Values Unavailable ]")); erase_data_content (_("[ Register Values Unavailable ]"));
@ -500,20 +500,6 @@ tui_data_window::do_scroll_vertical (int num_to_scroll)
/* See tui-regs.h. */ /* See tui-regs.h. */
void
tui_data_window::rerender ()
{
/* Delete all data item windows. */
for (auto &&win : regs_content)
{
tui_delete_win (win.handle);
win.handle = NULL;
}
display_all_data ();
}
/* See tui-regs.h. */
void void
tui_data_window::refresh_window () tui_data_window::refresh_window ()
{ {

4
gdb/tui/tui-regs.h
View File

@ -121,10 +121,6 @@ private:
past the register area (-1) is returned. */ past the register area (-1) is returned. */
int first_reg_element_no_inline (int line_no) const; int first_reg_element_no_inline (int line_no) const;
/* Displays the data that is in the data window's content. It does
not set the content. */
void display_all_data ();
/* Delete all the item windows in the data window. This is usually /* Delete all the item windows in the data window. This is usually
done when the data window is scrolled. */ done when the data window is scrolled. */
void delete_data_content_windows (); void delete_data_content_windows ();