espressif/binutils-gdb
1
0
Fork 0
mirror of https://github.com/espressif/binutils-gdb.git synced 2025-06-28 23:39:35 +08:00
Code Issues Packages Projects Releases Wiki Activity

Remove NULL checks before xfree

Browse Source 
A couple of spots in the TUI did a NULL check before an xfree.  This
isn't necessary, and most other cases were removed from gdb a while
ago.

gdb/ChangeLog
2019-06-25  Tom Tromey  <tom@tromey.com>

	* tui/tui-source.c (tui_set_source_content): Don't check before
	xfree.
	* tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
This commit is contained in:
Tom Tromey
2019-06-23 14:28:11 -06:00
parent 53e7cdbaa1
commit 17568d782d
3 changed files with 9 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
gdb/ChangeLog
View File

@ -1,3 +1,9 @@
2019-06-25 Tom Tromey <tom@tromey.com>
* tui/tui-source.c (tui_set_source_content): Don't check before
xfree.
* tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
2019-06-25 Tom Tromey <tom@tromey.com> 2019-06-25 Tom Tromey <tom@tromey.com>
* tui/tui-winsource.h (tui_update_source_window_as_is) * tui/tui-winsource.h (tui_update_source_window_as_is)

6
gdb/tui/tui-disasm.c
View File

@ -59,10 +59,8 @@ tui_disassemble (struct gdbarch *gdbarch, struct tui_asm_line *asm_lines,
/* Now construct each line. */ /* Now construct each line. */
for (; count > 0; count--, asm_lines++) for (; count > 0; count--, asm_lines++)
{ {
if (asm_lines->addr_string) xfree (asm_lines->addr_string);
xfree (asm_lines->addr_string); xfree (asm_lines->insn);
if (asm_lines->insn)
xfree (asm_lines->insn);
print_address (gdbarch, pc, &gdb_dis_out); print_address (gdbarch, pc, &gdb_dis_out);
asm_lines->addr = pc; asm_lines->addr = pc;

3
gdb/tui/tui-source.c
View File

@ -163,8 +163,7 @@ tui_set_source_content (struct symtab *s,
= (struct tui_source_window_base *) TUI_SRC_WIN; = (struct tui_source_window_base *) TUI_SRC_WIN;
const char *s_filename = symtab_to_filename_for_display (s); const char *s_filename = symtab_to_filename_for_display (s);
if (TUI_SRC_WIN->title) xfree (TUI_SRC_WIN->title);
xfree (TUI_SRC_WIN->title);
TUI_SRC_WIN->title = xstrdup (s_filename); TUI_SRC_WIN->title = xstrdup (s_filename);
xfree (src->fullname); xfree (src->fullname);