espressif/binutils-gdb
1
0
Fork 0
mirror of https://github.com/espressif/binutils-gdb.git synced 2025-06-21 02:24:17 +08:00
Code Issues Packages Projects Releases Wiki Activity

[gdb/testsuite] Fix gdb.base/write_mem.exp for big endian

Browse Source 
On s390x-linux (big endian), I run into:
...
(gdb) x /xh main^M
0x1000638 <main>:       0x0000^M
(gdb) FAIL: gdb.base/write_mem.exp: x /xh main
...

In contrast, on x86_64-linux (little endian), we have the expected:
...
(gdb) x /xh main^M
0x4004a7 <main>:        0x4242^M
(gdb) PASS: gdb.base/write_mem.exp: x /xh main
...

The problem is that the test-case hard-codes expectations about endiannes by
writing an int-sized value (4 bytes in this case) and then printing only a
halfword by using "/h" (so, two bytes).

If we print 4 bytes, we have for s390x:
...
0x1000638 <main>:       0x00004242^M
...
and for x86_64:
...
0x4004a7 <main>:        0x00004242^M
...

Fix this by removing the "/h".

Tested on x86_64-linux and s390x-linux.
This commit is contained in:
Tom de Vries
2022-12-12 14:25:58 +01:00
parent b5661ff24f
commit 167f3beb65
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
gdb/testsuite/gdb.base/write_mem.exp
View File

@ -42,6 +42,6 @@ gdb_test_no_output "set {int}main = 0x4242"
# Check that memory write persists after quitting GDB # Check that memory write persists after quitting GDB
gdb_exit gdb_exit
gdb_start gdb_start
gdb_test "x /xh main" "<main>:.*4242" gdb_test "x /x main" "<main>:.*4242"
set GDBFLAGS $old_gdbflags set GDBFLAGS $old_gdbflags