Make target_options_to_string return an std::string

Return an std::string instead of a char *, saving some manual freeing.

I only manually tested with "set debug target 1" and "set debug lin-lwp
1", since this only deals with debug output.

gdb/ChangeLog:

	* target.h (target_options_to_string): Return an std::string.
	* target.c (str_comma_list_concat_elem): Return void, use
	std::string.
	(do_option): Likewise.
	(target_options_to_string): Return an std::string.
	* linux-nat.c (linux_nat_target::wait): Adjust.
	* target-debug.h (target_debug_print_options): Adjust.
This commit is contained in:
Simon Marchi
2018-08-07 21:37:40 -04:00
parent b825f3a90e
commit 09ce46f230
5 changed files with 31 additions and 32 deletions

View File

@ -203,10 +203,9 @@ target_debug_print_struct_target_waitstatus_p (struct target_waitstatus *status)
static void
target_debug_print_options (int options)
{
char *str = target_options_to_string (options);
std::string str = target_options_to_string (options);
fputs_unfiltered (str, gdb_stdlog);
xfree (str);
fputs_unfiltered (str.c_str (), gdb_stdlog);
}
static void