espressif/binutils-gdb
1
0
Fork 0
mirror of https://github.com/espressif/binutils-gdb.git synced 2025-06-20 18:08:24 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fix ubsan signed integer overflow

Browse Source 
IMO a fairly useless warning in this case, but technically correct.

	PR 18708
	* i386-dis.c (get64): Avoid signed integer overflow.
This commit is contained in:
Alan Modra
2015-07-23 12:41:38 +09:30
parent 510fac86d7
commit 070fe95d07
2 changed files with 8 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
opcodes/ChangeLog
View File

@ -1,3 +1,8 @@
2015-07-23 Alan Modra <amodra@gmail.com>
PR 18708
* i386-dis.c (get64): Avoid signed integer overflow.
2015-07-22 Alexander Fomin <alexander.fomin@intel.com> 2015-07-22 Alexander Fomin <alexander.fomin@intel.com>
PR binutils/18631 PR binutils/18631

4
opcodes/i386-dis.c
View File

@ -15387,11 +15387,11 @@ get64 (void)
a = *codep++ & 0xff; a = *codep++ & 0xff;
a |= (*codep++ & 0xff) << 8; a |= (*codep++ & 0xff) << 8;
a |= (*codep++ & 0xff) << 16; a |= (*codep++ & 0xff) << 16;
a |= (*codep++ & 0xff) << 24; a |= (*codep++ & 0xffu) << 24;
b = *codep++ & 0xff; b = *codep++ & 0xff;
b |= (*codep++ & 0xff) << 8; b |= (*codep++ & 0xff) << 8;
b |= (*codep++ & 0xff) << 16; b |= (*codep++ & 0xff) << 16;
b |= (*codep++ & 0xff) << 24; b |= (*codep++ & 0xffu) << 24;
x = a + ((bfd_vma) b << 32); x = a + ((bfd_vma) b << 32);
#else #else
abort (); abort ();