mirror of
https://github.com/espressif/binutils-gdb.git
synced 2025-12-19 01:19:41 +08:00
[gdb/python] Throw MemoryError in inferior.read_memory if malloc fails
PR python/31631 reports a gdb internal error when doing: ... (gdb) python gdb.selected_inferior().read_memory (0, 0xffffffffffffffff) utils.c:709: internal-error: virtual memory exhausted. A problem internal to GDB has been detected, further debugging may prove unreliable. ... Fix this by throwing a python MemoryError, such that we have instead: ... (gdb) python gdb.selected_inferior().read_memory (0, 0xffffffffffffffff) Python Exception <class 'MemoryError'>: Error occurred in Python. (gdb) ... Likewise for DAP. Tested on x86_64-linux. Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=31631
This commit is contained in:
@@ -18,13 +18,17 @@ import base64
|
||||
import gdb
|
||||
|
||||
from .server import capability, request
|
||||
from .startup import DAPException
|
||||
|
||||
|
||||
@request("readMemory")
|
||||
@capability("supportsReadMemoryRequest")
|
||||
def read_memory(*, memoryReference: str, offset: int = 0, count: int, **extra):
|
||||
addr = int(memoryReference, 0) + offset
|
||||
buf = gdb.selected_inferior().read_memory(addr, count)
|
||||
try:
|
||||
buf = gdb.selected_inferior().read_memory(addr, count)
|
||||
except MemoryError as e:
|
||||
raise DAPException("Out of memory") from e
|
||||
return {
|
||||
"address": hex(addr),
|
||||
"data": base64.b64encode(buf).decode("ASCII"),
|
||||
|
||||
Reference in New Issue
Block a user