* compress.c (bfd_get_full_section_contents): Don't cache

decompressed contents.
This commit is contained in:
Tom Tromey
2012-10-19 15:51:53 +00:00
parent 99c7d5a823
commit 06c2e2c12c
2 changed files with 12 additions and 8 deletions

View File

@ -1,3 +1,8 @@
2012-10-19 Tom Tromey <tromey@redhat.com>
* compress.c (bfd_get_full_section_contents): Don't cache
decompressed contents.
2012-10-18 Kai Tietz <ktietz@redhat.com> 2012-10-18 Kai Tietz <ktietz@redhat.com>
PR binutils/14067 PR binutils/14067

View File

@ -165,7 +165,6 @@ bfd_get_full_section_contents (bfd *abfd, sec_ptr sec, bfd_byte **ptr)
bfd_size_type uncompressed_size; bfd_size_type uncompressed_size;
bfd_size_type rawsize; bfd_size_type rawsize;
bfd_byte *compressed_buffer; bfd_byte *compressed_buffer;
bfd_byte *uncompressed_buffer;
#endif #endif
if (abfd->direction != write_direction && sec->rawsize != 0) if (abfd->direction != write_direction && sec->rawsize != 0)
@ -220,24 +219,24 @@ bfd_get_full_section_contents (bfd *abfd, sec_ptr sec, bfd_byte **ptr)
if (!ret) if (!ret)
goto fail_compressed; goto fail_compressed;
uncompressed_buffer = (bfd_byte *) bfd_malloc (uncompressed_size); if (p == NULL)
if (uncompressed_buffer == NULL) p = (bfd_byte *) bfd_malloc (uncompressed_size);
if (p == NULL)
goto fail_compressed; goto fail_compressed;
if (!decompress_contents (compressed_buffer, compressed_size, if (!decompress_contents (compressed_buffer, compressed_size,
uncompressed_buffer, uncompressed_size)) p, uncompressed_size))
{ {
bfd_set_error (bfd_error_bad_value); bfd_set_error (bfd_error_bad_value);
free (uncompressed_buffer); free (p);
fail_compressed: fail_compressed:
free (compressed_buffer); free (compressed_buffer);
return FALSE; return FALSE;
} }
free (compressed_buffer); free (compressed_buffer);
sec->contents = uncompressed_buffer; *ptr = p;
sec->compress_status = COMPRESS_SECTION_DONE; return TRUE;
/* Fall thru */
#endif #endif
case COMPRESS_SECTION_DONE: case COMPRESS_SECTION_DONE: