espressif/binutils-gdb
1
0
Fork 0
mirror of https://github.com/espressif/binutils-gdb.git synced 2025-06-28 15:18:37 +08:00
Code Issues Packages Projects Releases Wiki Activity

Revert check-in by a mistake in the previous commit.

Browse Source 
gdb/ChangeLog
2016-04-06  Jan Kratochvil  <jan.kratochvil@redhat.com>

	* remote.c: Revert check-in by a mistake in the previous commit.
This commit is contained in:
Jan Kratochvil
2016-04-06 16:48:27 +02:00
parent fef3cb9f3a
commit 052d2eb254
2 changed files with 4 additions and 27 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
gdb/ChangeLog
View File

@ -1,3 +1,7 @@
2016-04-06 Jan Kratochvil <jan.kratochvil@redhat.com>
* remote.c: Revert check-in by a mistake in the previous commit.
2016-04-06 Jan Kratochvil <jan.kratochvil@redhat.com> 2016-04-06 Jan Kratochvil <jan.kratochvil@redhat.com>
Pedro Alves <palves@redhat.com> Pedro Alves <palves@redhat.com>

27
gdb/remote.c
View File

@ -1496,15 +1496,6 @@ enum {
static struct packet_config remote_protocol_packets[PACKET_MAX]; static struct packet_config remote_protocol_packets[PACKET_MAX];
/* gdbserver < 7.7 (before its fix from 2013-12-11) did reply to any
unknown 'v' packet with string "OK". "OK" gets interpreted by GDB
as a reply to known packet. For packet "vFile:setfs:" it is an
invalid reply and GDB would return error in
remote_hostio_set_filesystem, making remote files access impossible.
If this variable is non-zero it means the remote gdbserver is buggy
and any not yet detected packets are assumed as unsupported. */
static int unknown_v_replies_ok;
/* Returns the packet's corresponding "set remote foo-packet" command /* Returns the packet's corresponding "set remote foo-packet" command
state. See struct packet_config for more details. */ state. See struct packet_config for more details. */
@ -1528,9 +1519,6 @@ packet_config_support (struct packet_config *config)
case AUTO_BOOLEAN_FALSE: case AUTO_BOOLEAN_FALSE:
return PACKET_DISABLE; return PACKET_DISABLE;
case AUTO_BOOLEAN_AUTO: case AUTO_BOOLEAN_AUTO:
if (unknown_v_replies_ok && config->name != NULL
&& config->name[0] == 'v')
return PACKET_DISABLE;
return config->support; return config->support;
default: default:
gdb_assert_not_reached (_("bad switch")); gdb_assert_not_reached (_("bad switch"));
@ -4035,21 +4023,6 @@ remote_start_remote (int from_tty, struct target_ops *target, int extended_p)
if (packet_support (PACKET_QAllow) != PACKET_DISABLE) if (packet_support (PACKET_QAllow) != PACKET_DISABLE)
remote_set_permissions (target); remote_set_permissions (target);
/* See unknown_v_replies_ok description. */
{
const char v_mustreplyempty[] = "vMustReplyEmpty";
putpkt (v_mustreplyempty);
getpkt (&rs->buf, &rs->buf_size, 0);
if (strcmp (rs->buf, "OK") == 0)
unknown_v_replies_ok = 1;
else if (strcmp (rs->buf, "") == 0)
unknown_v_replies_ok = 0;
else
error (_("Remote replied unexpectedly to '%s': %s"), v_mustreplyempty,
rs->buf);
}
/* Next, we possibly activate noack mode. /* Next, we possibly activate noack mode.
If the QStartNoAckMode packet configuration is set to AUTO, If the QStartNoAckMode packet configuration is set to AUTO,