Consolidate partial symtab dependency reading

Most of the symbol readers have code to iterate over a partial symtabs
dependencies, expanding each one and optionally printing a message.
Now that the "second-stage" psymtab expansion is available as a
method, these implementations can all be merged.

This patch also changes a couple more warnings into assertions.

gdb/ChangeLog
2020-01-26  Tom Tromey  <tom@tromey.com>

	* xcoffread.c (xcoff_psymtab_to_symtab_1): Call
	read_dependencies.  Add assert.
	* psymtab.c (partial_symtab::read_dependencies): New method.
	* psympriv.h (struct partial_symtab) <read_dependencies>: New
	method.
	* mdebugread.c (psymtab_to_symtab_1): Call read_dependencies.
	* dwarf2read.c (dwarf2_psymtab::expand_psymtab): Call
	read_dependencies.
	* dbxread.c (dbx_psymtab_to_symtab_1): Call read_dependencies.
	Add assert.

Change-Id: I8151e05677794e90223edc1a4cb70f7f69137d46
This commit is contained in:
Tom Tromey
2019-10-23 09:46:25 -06:00
parent 8566b89b73
commit 0494dbecdf
7 changed files with 48 additions and 90 deletions

View File

@ -134,6 +134,9 @@ struct partial_symtab
expand_psymtab can be made. */
virtual void expand_psymtab (struct objfile *) = 0;
/* Ensure that all the dependencies are read in. */
void read_dependencies (struct objfile *);
/* Return the raw low text address of this partial_symtab. */
CORE_ADDR raw_text_low () const
{