Use obstack_strdup more

This changes gdb to use obstack_strdup when appropriate, rather than
the wordier obstack_copy0.

gdb/ChangeLog
2019-08-06  Tom Tromey  <tom@tromey.com>

	* xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
	obstack_strdup.
	* typeprint.c (typedef_hash_table::find_global_typedef): Use
	obstack_strdup.
	* symfile.c (allocate_compunit_symtab): Use obstack_strdup.
	* stabsread.c (common_block_start): Use obstack_strdup.
	* objfiles.c (set_objfile_main_name, objfile): Use
	obstack_strdup.
	* namespace.c (add_using_directive): Use obstack_strdup.
	* mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
	* jit.c (finalize_symtab): Use obstack_strdup.
	* dwarf2read.c (fixup_go_packaging, dwarf2_physname)
	(guess_partial_die_structure_name, partial_die_info::fixup)
	(dwarf2_name): Use obstack_strdup.
	* coffread.c (coff_read_struct_type, coff_read_enum_type): Use
	obstack_strdup.
	* c-exp.y (scan_macro_expansion): Use obstack_strdup.
	* buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
	obstack_strdup.
	* ada-lang.c (ada_decode_symbol): Use obstack_strdup.
This commit is contained in:
Tom Tromey
2019-05-18 15:56:03 -06:00
parent b3c6d7ff98
commit 021887d88a
14 changed files with 57 additions and 72 deletions

View File

@ -87,10 +87,8 @@ add_using_directive (struct using_direct **using_directives,
if (copy_names)
{
newobj->import_src
= (const char *) obstack_copy0 (obstack, src, strlen (src));
newobj->import_dest
= (const char *) obstack_copy0 (obstack, dest, strlen (dest));
newobj->import_src = obstack_strdup (obstack, src);
newobj->import_dest = obstack_strdup (obstack, dest);
}
else
{
@ -99,15 +97,12 @@ add_using_directive (struct using_direct **using_directives,
}
if (alias != NULL && copy_names)
newobj->alias
= (const char *) obstack_copy0 (obstack, alias, strlen (alias));
newobj->alias = obstack_strdup (obstack, alias);
else
newobj->alias = alias;
if (declaration != NULL && copy_names)
newobj->declaration
= (const char *) obstack_copy0 (obstack, declaration,
strlen (declaration));
newobj->declaration = obstack_strdup (obstack, declaration);
else
newobj->declaration = declaration;