espressif/binutils-gdb
1
0
Fork 0
mirror of https://github.com/espressif/binutils-gdb.git synced 2025-06-28 07:08:01 +08:00
Code Issues Packages Projects Releases Wiki Activity

* symtab.c (find_pc_line): Fix comments.

Browse Source
This commit is contained in:
Jim Kingdon
1993-09-27 16:34:29 +00:00
parent 7fc6a6b52e
commit 01d3fdba2c
2 changed files with 11 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
gdb/ChangeLog
View File

@ -1,5 +1,7 @@
Mon Sep 27 10:22:37 1993 Jim Kingdon (kingdon@lioth.cygnus.com) Mon Sep 27 10:22:37 1993 Jim Kingdon (kingdon@lioth.cygnus.com)
* symtab.c (find_pc_line): Fix comments.
* remote-udi.c (udi_mourn): Don't pop target. * remote-udi.c (udi_mourn): Don't pop target.
Fri Sep 24 17:25:41 1993 Stu Grossman (grossman at cygnus.com) Fri Sep 24 17:25:41 1993 Stu Grossman (grossman at cygnus.com)

22
gdb/symtab.c
View File

@ -382,7 +382,7 @@ find_pc_psymbol (psymtab, pc)
struct partial_symtab *psymtab; struct partial_symtab *psymtab;
CORE_ADDR pc; CORE_ADDR pc;
{ {
struct partial_symbol *best, *p; struct partial_symbol *best = NULL, *p;
CORE_ADDR best_pc; CORE_ADDR best_pc;
if (!psymtab) if (!psymtab)
@ -430,7 +430,7 @@ lookup_symbol (name, block, namespace, is_a_field_of_this, symtab)
struct symtab **symtab; struct symtab **symtab;
{ {
register struct symbol *sym; register struct symbol *sym;
register struct symtab *s; register struct symtab *s = NULL;
register struct partial_symtab *ps; register struct partial_symtab *ps;
struct blockvector *bv; struct blockvector *bv;
register struct objfile *objfile; register struct objfile *objfile;
@ -991,15 +991,7 @@ find_pc_symtab (pc)
code in the middle of a subroutine. To properly find the end of a line's PC code in the middle of a subroutine. To properly find the end of a line's PC
range, we must search all symtabs associated with this compilation unit, and range, we must search all symtabs associated with this compilation unit, and
find the one whose first PC is closer than that of the next line in this find the one whose first PC is closer than that of the next line in this
symtab. symtab. */
FIXME: We used to complain here about zero length or negative length line
tables, but there are two problems with this: (1) some symtabs may not have
any line numbers due to gcc -g1 compilation, and (2) this function is called
during single stepping, when we don't own the terminal and thus can't
produce any output. One solution might be to implement a mechanism whereby
complaints can be queued until we regain control of the terminal. -fnf
*/
/* If it's worth the effort, we could be using a binary search. */ /* If it's worth the effort, we could be using a binary search. */
@ -1065,8 +1057,12 @@ find_pc_line (pc, notcurrent)
if (!l) if (!l)
continue; continue;
len = l->nitems; len = l->nitems;
if (len <= 0) /* See FIXME above. */ if (len <= 0)
{ {
/* I think len can be zero if the symtab lacks line numbers
(e.g. gcc -g1). (Either that or the LINETABLE is NULL;
I'm not sure which, and maybe it depends on the symbol
reader). */
continue; continue;
} }
@ -2775,7 +2771,7 @@ make_symbol_completion_list (text, word)
{ {
char *p; char *p;
char quote_found; char quote_found;
char *quote_pos; char *quote_pos = NULL;
/* First see if this is a quoted string. */ /* First see if this is a quoted string. */
quote_found = '\0'; quote_found = '\0';