espressif/binutils-gdb
1
0
Fork 0
mirror of https://github.com/espressif/binutils-gdb.git synced 2025-06-20 01:50:24 +08:00
Code Issues Packages Projects Releases Wiki Activity

gdb/dwarf: add some QUIT macros

Browse Source 
While testing the fix for PR 29105, I noticed I couldn't ctrl-C my way
out of GDB expanding many symtabs.  GDB was busy in a loop in
cooked_index_functions::expand_symtabs_matching.  Add a QUIT there.  I
also happened to see a spot in
cooked_index_functions::expand_matching_symbols where a QUIT would be
useful too, since we iterate over a potentially big number of index
entries and expand CUs in the loop.  Add one there too.

Change-Id: Ie1d650381df7f944c16d841b3e592d2dce7306c3
Approved-By: Kevin Buettner <kevinb@redhat.com>
This commit is contained in:
Simon Marchi
2022-12-01 11:44:41 -05:00
parent 616d7b31c8
commit 00a5867df7
1 changed files with 4 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
gdb/dwarf2/read.c
View File

@ -18653,6 +18653,8 @@ cooked_index_functions::expand_matching_symbols
(per_objfile->per_bfd->index_table.get ())); (per_objfile->per_bfd->index_table.get ()));
for (const cooked_index_entry *entry : table->all_entries ()) for (const cooked_index_entry *entry : table->all_entries ())
{ {
QUIT;
if (entry->parent_entry != nullptr) if (entry->parent_entry != nullptr)
continue; continue;
@ -18728,6 +18730,8 @@ cooked_index_functions::expand_symtabs_matching
for (const cooked_index_entry *entry : table->find (name_vec.back (), for (const cooked_index_entry *entry : table->find (name_vec.back (),
completing)) completing))
{ {
QUIT;
/* No need to consider symbols from expanded CUs. */ /* No need to consider symbols from expanded CUs. */
if (per_objfile->symtab_set_p (entry->per_cu)) if (per_objfile->symtab_set_p (entry->per_cu))
continue; continue;