espressif/Unity
1
0
Fork 0
mirror of https://github.com/ThrowTheSwitch/Unity.git synced 2025-07-12 15:10:22 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fix Leak Detection always passing, but printing a fail message

Browse Source 
Don't set CurrentTestFailed = 0 at end, move before last check
 These tests now fail if the output_Spy is not used instead of putchar()
This commit is contained in:
jsalling
2015-12-16 17:21:09 -06:00
parent 81cf5eb626
commit c629e120e1
1 changed files with 3 additions and 3 deletions

6
extras/fixture/test/unity_fixture_Test.c

@ -316,9 +316,9 @@ TEST(LeakDetection, DetectsLeak)
UnityMalloc_EndTest(); UnityMalloc_EndTest();
EXPECT_ABORT_END EXPECT_ABORT_END
UnityOutputCharSpy_Enable(0); UnityOutputCharSpy_Enable(0);
Unity.CurrentTestFailed = 0;
CHECK(strstr(UnityOutputCharSpy_Get(), "This test leaks!")); CHECK(strstr(UnityOutputCharSpy_Get(), "This test leaks!"));
free(m); free(m);
Unity.CurrentTestFailed = 0;
} }
TEST(LeakDetection, BufferOverrunFoundDuringFree) TEST(LeakDetection, BufferOverrunFoundDuringFree)
@ -331,8 +331,8 @@ TEST(LeakDetection, BufferOverrunFoundDuringFree)
free(m); free(m);
EXPECT_ABORT_END EXPECT_ABORT_END
UnityOutputCharSpy_Enable(0); UnityOutputCharSpy_Enable(0);
CHECK(strstr(UnityOutputCharSpy_Get(), "Buffer overrun detected during free()"));
Unity.CurrentTestFailed = 0; Unity.CurrentTestFailed = 0;
CHECK(strstr(UnityOutputCharSpy_Get(), "Buffer overrun detected during free()"));
} }
TEST(LeakDetection, BufferOverrunFoundDuringRealloc) TEST(LeakDetection, BufferOverrunFoundDuringRealloc)
@ -345,6 +345,6 @@ TEST(LeakDetection, BufferOverrunFoundDuringRealloc)
m = realloc(m, 100); m = realloc(m, 100);
EXPECT_ABORT_END EXPECT_ABORT_END
UnityOutputCharSpy_Enable(0); UnityOutputCharSpy_Enable(0);
CHECK(strstr(UnityOutputCharSpy_Get(), "Buffer overrun detected during realloc()"));
Unity.CurrentTestFailed = 0; Unity.CurrentTestFailed = 0;
CHECK(strstr(UnityOutputCharSpy_Get(), "Buffer overrun detected during realloc()"));
} }