espressif/Unity
1
0
Fork 0
mirror of https://github.com/ThrowTheSwitch/Unity.git synced 2025-10-11 17:06:54 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fix error in example_1

Browse Source 
This test case had an error:
test_FindFunction_WhichIsBroken_ShouldReturnZeroIfItemIsNotInList_WhichWorksEvenInOurBrokenCode
It was supposed to be a list of values that are NOT in the list,
and none of them should be found.  It incorrectly included '1'
which is a value in the list.

The compile option -Wno-misleading-indentation was also added to
remove a compiler warning produced by gcc 7.3.0
This commit is contained in:
teaguecl
2019-01-25 21:22:55 -08:00
parent 38c48704c5
commit 9d1ffe26d6
2 changed files with 7 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
examples/example_1/makefile
View File

@ -41,6 +41,7 @@ CFLAGS += -Wno-unknown-pragmas
CFLAGS += -Wstrict-prototypes CFLAGS += -Wstrict-prototypes
CFLAGS += -Wundef CFLAGS += -Wundef
CFLAGS += -Wold-style-definition CFLAGS += -Wold-style-definition
CFLAGS += -Wno-misleading-indentation
TARGET_BASE1=test1 TARGET_BASE1=test1
TARGET_BASE2=test2 TARGET_BASE2=test2

12
examples/example_1/test/TestProductionCode.c
View File

@ -5,7 +5,7 @@
/* sometimes you may want to get at local data in a module. /* sometimes you may want to get at local data in a module.
* for example: If you plan to pass by reference, this could be useful * for example: If you plan to pass by reference, this could be useful
* however, it should often be avoided */ * however, it should often be avoided */
extern int Counter; extern int Counter;
void setUp(void) void setUp(void)
{ {
@ -21,7 +21,7 @@ void test_FindFunction_WhichIsBroken_ShouldReturnZeroIfItemIsNotInList_WhichWork
{ {
/* All of these should pass */ /* All of these should pass */
TEST_ASSERT_EQUAL(0, FindFunction_WhichIsBroken(78)); TEST_ASSERT_EQUAL(0, FindFunction_WhichIsBroken(78));
TEST_ASSERT_EQUAL(0, FindFunction_WhichIsBroken(1)); TEST_ASSERT_EQUAL(0, FindFunction_WhichIsBroken(2));
TEST_ASSERT_EQUAL(0, FindFunction_WhichIsBroken(33)); TEST_ASSERT_EQUAL(0, FindFunction_WhichIsBroken(33));
TEST_ASSERT_EQUAL(0, FindFunction_WhichIsBroken(999)); TEST_ASSERT_EQUAL(0, FindFunction_WhichIsBroken(999));
TEST_ASSERT_EQUAL(0, FindFunction_WhichIsBroken(-1)); TEST_ASSERT_EQUAL(0, FindFunction_WhichIsBroken(-1));
@ -31,9 +31,9 @@ void test_FindFunction_WhichIsBroken_ShouldReturnTheIndexForItemsInList_WhichWil
{ {
/* You should see this line fail in your test summary */ /* You should see this line fail in your test summary */
TEST_ASSERT_EQUAL(1, FindFunction_WhichIsBroken(34)); TEST_ASSERT_EQUAL(1, FindFunction_WhichIsBroken(34));
/* Notice the rest of these didn't get a chance to run because the line above failed. /* Notice the rest of these didn't get a chance to run because the line above failed.
* Unit tests abort each test function on the first sign of trouble. * Unit tests abort each test function on the first sign of trouble.
* Then NEXT test function runs as normal. */ * Then NEXT test function runs as normal. */
TEST_ASSERT_EQUAL(8, FindFunction_WhichIsBroken(8888)); TEST_ASSERT_EQUAL(8, FindFunction_WhichIsBroken(8888));
} }
@ -42,7 +42,7 @@ void test_FunctionWhichReturnsLocalVariable_ShouldReturnTheCurrentCounterValue(v
{ {
/* This should be true because setUp set this up for us before this test */ /* This should be true because setUp set this up for us before this test */
TEST_ASSERT_EQUAL_HEX(0x5a5a, FunctionWhichReturnsLocalVariable()); TEST_ASSERT_EQUAL_HEX(0x5a5a, FunctionWhichReturnsLocalVariable());
/* This should be true because we can still change our answer */ /* This should be true because we can still change our answer */
Counter = 0x1234; Counter = 0x1234;
TEST_ASSERT_EQUAL_HEX(0x1234, FunctionWhichReturnsLocalVariable()); TEST_ASSERT_EQUAL_HEX(0x1234, FunctionWhichReturnsLocalVariable());