3190 Commits

Author SHA1 Message Date
7a695784bc Add queue.c CMock unit test (#552)
* Disregard coverage data without a function_name field set

* Fix calling make on subdirectories

* Undefine FORTIFY_SOURCE when running without ENABLE_SANITIZERS

* Add queue and semaphore unit tests

* Update FreeRTOS-Kernel submodule revision
2021-04-20 15:45:52 -07:00
53af0ec62e Revert "Add test for timer start delayed past expiration (#557)" (#566)
This reverts commit 9c911990164abb4939d08fc3ebeccc5f2199c6cb.
2021-04-17 15:50:15 -07:00
9c91199016 Add test for timer start delayed past expiration (#557)
Co-authored-by: Dan Good <49254594+dan4thewin@users.noreply.github.com>
Co-authored-by: RichardBarry <3073890+RichardBarry@users.noreply.github.com>
2021-04-17 15:02:47 -07:00
2560a50a7b prune .git from versioning search (#561)
Co-authored-by: Archit Aggarwal <architag@amazon.com>
2021-04-16 18:11:38 -07:00
999e81e721 Bump submodules of Kernel and AWS libraries (#564) 2021-04-16 16:11:05 -07:00
4249f5ce11 Update README cloning instructions to set core.symlinks for Windows (#556)
* Update README cloning instructions to set core.symlinks for Windows

* Add purpose
2021-04-14 10:08:39 -07:00
5440581dcd Fix typo in History.txt (#559) 2021-04-13 17:39:33 -07:00
cd75d5607f Relocate History.txt and fix an typo (#558) 2021-04-13 16:52:26 -07:00
f2bcfb3866 Add test for backlogged auto-reload timer (#553)
* Add test for backlogged auto-reset timer

Must call vTimerDemoIncludeBacklogTests() to activate.

* Fix little style issues

- Update to new header
- Add parentheses (style)
- Remove trailing space accidentally introduced

* Don't verify full clearing of backlog

The timer task should be free to process the stop request without a
specific requirement to work through the backlog of callbacks for the
stopped timer.  The timer task should be allowed to cancel the entire
backlog, part of it, or none of it.  In other words, once the
application sends the stop request, it should not depend on receiving
any more callbacks, even backlogged ones.

The only requirement here is that the timer stop as requested.

Co-authored-by: Joseph Julicher <jjulicher@mac.com>
Co-authored-by: Cobus van Eeden <35851496+cobusve@users.noreply.github.com>
2021-04-12 16:39:17 -07:00
1f47a22b23 Add MQTT Agent submodule (#551)
* Add MQTT Agent submodule

* Add MQTT agent platform files

Co-authored-by: abhidixi11 <44424462+abhidixi11@users.noreply.github.com>
Co-authored-by: Joseph Julicher <jjulicher@mac.com>
2021-04-09 11:17:06 -07:00
c280f26c1b Small RISC-V spike demo improvements (#554)
* Put XLEN into .o files.

Makes it easier to work on voth RV32 and RV64 binaries side-by-side.

* Let the debugger disable HTIF use.

* Makefile now links the binary at BASE_ADDRESS

I need this so I can easily generate the appropriate binaries for
riscv-tests/debug. Unfortunately there doesn't seem to be any good
mechanism to externally define values for lds files, so I'm running it
through the C preprocessor.

Co-authored-by: Joseph Julicher <jjulicher@mac.com>
2021-04-08 15:03:10 -07:00
f87eb7d0d4 Bump pyyaml from 5.3.1 to 5.4 in /.github/scripts/common (#555)
Bumps [pyyaml](https://github.com/yaml/pyyaml) from 5.3.1 to 5.4.
- [Release notes](https://github.com/yaml/pyyaml/releases)
- [Changelog](https://github.com/yaml/pyyaml/blob/master/CHANGES)
- [Commits](https://github.com/yaml/pyyaml/compare/5.3.1...5.4)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-04-08 13:02:16 -07:00
595b05bce8 Fix spelling in stream_buffer_utest.c 2021-04-07 13:56:04 -07:00
58b1f9b27d Fix spelling in message_buffer_utest.c 2021-04-07 13:56:04 -07:00
308739464b Update test comments
Signed-off-by: Gaurav Aggarwal <aggarg@amazon.com>
(cherry picked from commit 44c66f1df24c9f9a26f218de1b6c1dd816f12a8b)
2021-04-07 13:56:04 -07:00
5c7f33fbfb Fix typo in message_buffer_utest.c 2021-04-07 13:56:04 -07:00
c82e6caa34 Remove imporper TEST_PROTECT usage from message_buffer_utest.c.
The way TEST_PROTECT is currently used in this test causes an infinite loop if the expected configASSERT failure does not occur.
2021-04-07 13:56:04 -07:00
68cb6142ae Remove improper TEST_PROTECT usage which results in an infinite loop when an expected configASSERT does not occur.
Replace TEST_PROTECT usage with CException library.

Fix test_xStreamBufferSend_zero_bytes test case logic (no assertion occurs in this case).
2021-04-07 13:56:04 -07:00
d0d633a524 Reintroduce quarantined CBMC test (#516)
This CBMC test would go over the memory limit of most hosts, causing the
kernel to kill the process. With larger memory capabilities, this can be
re-enabled.
2021-04-07 12:26:03 -07:00
8dafa9fe4a Run kernel unit tests against FreeRTOS-Kernel repository main branch and the current submodule version. 2021-04-06 13:01:33 -07:00
3fee3ac61f Add RISC-V demo for the spike simulator. (#532)
* Add RISC-V demo for the spike simulator.

* Figuring out what the header checker wants.

* Fix more headers.

* Ignore htif.c and htif.h for header checks.

These files are already stamped with BSD-3-Clause, which I'm not allowed
to remove. There are numerous other files with the same license in
FreeRTOS, so I assume this is fine.

* Use proxy syscalls for RV32.

Looks like spike won't be changed to make htif character writes work
propery for RV32.

This is now an even closer copy of the version in opensbi, which is
arguably strictly better.

* Support RV64 builds to use with spike.

OpenOCD does not currently support debugging 64-bit FreeRTOS, but now
that I have a target to test hopefully that will be remedied shortly.

* Tweak rv32 instructions.

This way you can have separate cross-tools installations that can
coexist side by side.

Co-authored-by: Joseph Julicher <jjulicher@mac.com>
2021-04-02 14:17:53 -07:00
aaece95529 Update Tasks.c CBMC Proofs to Latest Code (#547)
* Fix Tasks.c patch, line numbers were out of sync and patching was
broken.
* Add assumption to TaskCreate proof that a task's priority is less than
the configured max.

With the introduction of
9efe10b805
an assertion is added to ensure a new task's priority is less than the
confirmed max. The CBMC proof for TaskCreate needs to include this assumption
in order to not assert and fail. Since this is now enforced in the code
we can add an assumption to the proof that a task must be created with a
priority smaller than the configured max.
2021-04-02 14:17:26 -07:00
2e084538a8 Re-enable list, message_buffer, and stream_buffers unit tests 2021-04-01 10:52:03 -07:00
fb0c517148 Add event_groups.c Unit Test (#536)
* Added event_groups.c Unit Test.

* Formatted and more comments.

* Formatted

* Split some test cases and add comment and coverage tag.

* Update test cases.

* Remove xEventGroupDelete Invalid Input test case, since the implementation does not handle this.
2021-04-01 01:57:42 -07:00
19271ddc8d Work around gcov json output bug
When gcov outputs into it's intermediate json format, sometimes it marks blocks as unexecuted but also sets an execution count != 0. In this case, the "count" field is correct, but the "unexecuted_block" field is incorrect.

When outputting lcov formatted coverage data in filtercov.py, only output a branch coverage data lines (BRDA) with a "-" for the "taken" field when both count==0 and unexecuted_block==true in the input gcov json intermediate file.
2021-03-31 13:28:45 -07:00
e39c34ba7e Adding unit tests for stream buffer and message buffer (#528)
* Initial commit

* Add more stream buffer tests

* Adding message buffer tests

* Adding tests to cover config assert branches

Co-authored-by: alfred gedeon <28123637+alfred2g@users.noreply.github.com>
2021-03-30 12:56:02 -07:00
7020db5403 Force a branch in the definition of configASSERT in the default CMock FreeRTOSConfig.h file (#538)
* Force a branch in the definition of configASSERT in the default CMock FreeRTOSConfig.h file
* Run uncrustify on FreeRTOSConfig.h
2021-03-24 13:08:15 -07:00
92aca6e910 Collect initial coverage data so that untagged functions are still included in the lcov report (#537)
Collect initial coverage data with lcov --initial and add this to coverage data to the combined coverage from each test binary.
This ensures that all functions in the target file(s) are included in coverage statistics, even if those functions are not tagged in a _utest.c file.
Note: Functions which are excluded by the preprocessor will not have initial coverage data generated for them.
2021-03-23 18:41:14 -07:00
ada298638c Run kernel unit tests on pull requests and pushes.
Remove path filter (doesn't appear to work with multiple targets)
2021-03-22 15:09:05 -07:00
3a48781a03 Skip filtering of coverage if no @coverage tags are found in a _utest.c file 2021-03-22 14:58:52 -07:00
26478d721f Add message buffer space available coherency test (#515)
* Introduce tasks that test the coherency of the reported space available in a message buffer from two separate tasks.  Designed to highlight the issue reported in https://github.com/FreeRTOS/FreeRTOS-Kernel/pull/264
Introduce configRUN_ADDITIONAL_TESTS which must be set to 1 to run the new tests.  That is because the new tests got added to an existing standard demo file and smaller platforms may not have the resources to run them.
Set configRUN_ADDITIONAL_TESTS to 1 in the MSVC and IAR/QEMU project so both project run the new test.
Also add missing 'volatile' qualifier in the IAR/QEMU project on some register accesses.

* Update xAreMessageBufferTasksStillRunning() to report errors from the new message buffer size coherency tests.

Co-authored-by: RichardBarry <ribarry@amazon.com>
Co-authored-by: RichardBarry <3073890+RichardBarry@users.noreply.github.com>
2021-03-20 11:50:16 -07:00
f39765be22 Kernel UT: Enable preprocessor when running cflow in callgraph.py (#530)
* Add INCLUDE_DIR to the commandline call to cflow in callgraph.py

This removes dependent functions from the list when they are disabled in the FreeRTOS config.

* Add argparse to callgraph.py so that no output file is created on failure.
2021-03-19 17:30:20 -07:00
f1da2515c2 Run kernel CMock unit tests when they are changed. (#531)
* Run kernel unit tests in a github action only when Unit Test files change
2021-03-19 10:06:07 -07:00
270474aed4 Update serial.c for latest microchip DFP (1.6.88 from 1.1.40) (#517)
Update line 58 to make compatible with Microchip DFP 1.6.88


Co-authored-by: Joshua Yan <52796499+yanjos-dev@users.noreply.github.com>
2021-03-18 10:58:15 -07:00
ee1940bdb9 update configurations.xml to use the latest Microchip AVR DFP 1.6.88 (#518) 2021-03-16 17:16:21 -07:00
6257160ee6 Make the address sanitizer optional for CMock kernel unit tests (#526)
* Make the address sanitizer optional

The address sanitizer is now disabled by default for CMock tests because it introduces additional branches into the compiled code. When make is run with the ENABLE_SANITIZER=1 argument, the address sanitizer is enabled and coverage data may not be accurate.

* Change from ifdef to ifeq ($(ENABLE_SANITIZER),1) to address PR comment
2021-03-16 13:55:01 -07:00
cbc96ff596 Demo: remove commented code, and unused macros (#525) 2021-03-16 09:52:47 -07:00
d7e5f40885 Clean up CMock makefiles and add coverage filtering (#523)
* Cleanup Makefiles

* Add lcovrc configuration file

* Add CMock test build directory to .gitignore

* Add callgraph.py and filtercov.py scripts

* Cleanup list Makefile and update list_utest.c with coverage tags

* Add information about coverage filtering and running single test cases

* Remove -fprofile-exclude-files for compatibility with older versions of gcc.
Fix line endings (change to unix style)

* Lint callgraph.py and filtercov.py. Print and error when no target functions are defined.

* Indent with spaces when possible

* Replace tabs with spaces and enable .RECIPEPREFIX

* Add fake_port.h and related portmacro.h changes

* Fix list makefile when bin directory is not available

* Clean up grouped rules

* Update makesfile.. Add "two_tests" example dir

* Fix memory checker error

* Move common makefile items to subdir.mk and testdir.mk includes

* Update core_checker.py exclusions

* Remove line from portmacro.h that doesn't match core_checker.py
2021-03-15 17:01:29 -07:00
c8fa483b68 Add custom metrics to defender demo (#507)
Adds custom metrics to the defender demo. The metrics added are a list of the task ids and the stack high water mark.
2021-03-05 17:56:28 -08:00
e61730c9b1 Changed git-secrets check to check all PR branches. (#521)
* Change to check all PR branches.
2021-03-05 13:59:28 -08:00
7de2a488b8 Added git-secrets check to Github Action (#520) 2021-03-04 11:40:24 -08:00
5309372245 Minor VeriFast proof changes to match V10.4.3 (#519)
* Minor changes for V10.4.3

* Update license
2021-02-25 14:00:22 -07:00
5ff9863249 Update corePKCS11 submodule. (#505)
Co-authored-by: alfred gedeon <28123637+alfred2g@users.noreply.github.com>
2021-02-22 11:31:18 -08:00
47052bc054 Correct FreeRTOS.org link in main_full.c for: (#510)
* FreeRTOS/Demo/CORTEX_M3_MPS2_QEMU_GCC/main_full.c
* FreeRTOS/Demo/Posix_GCC/main_full.c
2021-02-22 10:37:23 -08:00
2e4485a0d6 Create Cortex-M3 QEMU project for testing with the IAR compiler (#503)
* Initial version of the CORTEX_MPS2_QEMU_IAR - needs tidying up and so far only contains the comprehensive demo.

* Update the comment block at the top of the source files to match the latest official release.

* Split out the main_full() demo from main().  Still need to add in the main_blinky() demo.

* Add the blinky demo option.

* Tidy up the QEMU/IAR project.

* Configure the QEMU IAR project to only create the blinky demo.

* Delete readme.txt which was in the wrong directory.

* Fix errors in the comments at the top of the file as highlighted by the auto checks.

Co-authored-by: alfred gedeon <28123637+alfred2g@users.noreply.github.com>
2021-02-19 12:19:23 -08:00
006c6dd5fd Update python version to 3.7.10 (#512) 2021-02-18 18:55:29 -08:00
570ae6bb52 Add unity memory extension, fake_assert, and enable -fsanitize=address (#506)
* Enable libunitymemory extension to track dynamic memory usage during unit tests
* Use UnityMemory in timers_utest.c
* Add fake_assert.h to allow mocking of configASSERT calls
* Add .editorconfig to make github show indentation correctly
* Add unity memory and fake_assert to queue_utest.c
* Add -fsanitize=address CFLAG when running unit tests
* Define mtCOVERAGE_TEST_MARKER macro to include mtCOVERAGE_TEST_MARKER lines in coverage figures
* Add additional memory check / protection CFLAGS for CMock tests
* Fix out of bounds array access in list_utest.c
* Move the fake_assert.h include to the top of FreeRTOSConfig.h
2021-02-18 10:15:01 -08:00
c4d8002634 Generate JUnit style report for kernel unit test (#504)
* Add JUnit test report to ut
* Add JUnit test report with make run
* Fix gcc path
2021-02-15 14:09:24 -08:00
63aec3607d Unit Test/timer[0] (#502)
* define CC/LD iff undef. Add timers suite

* timers_utest[0]
2021-02-14 11:24:55 -08:00
f6dff3fea3 Add Litani to run CBMC proofs (#501)
Update to out of source makefile build and add run-cbmc-proofs.py

CBMC proofs can now be run with Litani with the command
"./run-cbmc-proofs.py"

Based on commits:
* 1646301 - Ignore CBMC proof failures, fail the build later (4 months ago) <Kareem Khazem>
* 7e8c91a - Fix Makefile prerequisite symbol for CBMC proofs (4 months ago) <Kareem Khazem>
* bee04be - Enable CBMC proofs to run in CI (4 months ago) <Kareem Khazem>

Found in https://github.com/FreeRTOS/FreeRTOS-Plus-TCP
2021-02-12 10:21:07 -08:00