espressif/ESP8266_RTOS_SDK
1
0
Fork 0
mirror of https://github.com/espressif/ESP8266_RTOS_SDK.git synced 2025-05-20 08:36:41 +08:00
Code Issues Packages Projects Releases Wiki Activity

Merge branch 'feature/https_ota_support_no_verify' into 'master'

Browse Source 
esp_https_ota: SSL supports no verification

See merge request sdk/ESP8266_RTOS_SDK!1123
This commit is contained in:
Dong Heng
2019-10-14 15:31:46 +08:00
parent 81655f396f 8e76fa1130
commit ce3d47768d
2 changed files with 13 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
components/esp_https_ota/Kconfig
View File

@ -9,4 +9,13 @@ config OTA_BUF_SIZE
This buffer size depends on CONFIG_HTTP_BUF_SIZE. If you want to enlarge ota buffer size, please also enlarge CONFIG_HTTP_BUF_SIZE. This buffer size depends on CONFIG_HTTP_BUF_SIZE. If you want to enlarge ota buffer size, please also enlarge CONFIG_HTTP_BUF_SIZE.
OTA_BUF_SIZE equals to 1460 can save 40% upgrade time in contrast to OTA_BUF_SIZE which equals to 256. OTA_BUF_SIZE equals to 1460 can save 40% upgrade time in contrast to OTA_BUF_SIZE which equals to 256.
config OTA_ALLOW_HTTP
bool "Allow HTTP for OTA (WARNING: ONLY FOR TESTING PURPOSE, READ HELP)"
default n
help
It is highly recommended to keep HTTPS (along with server certificate validation) enabled.
Enabling this option comes with potential risk of:
- Non-encrypted communication channel with server
- Accepting firmware upgrade image from server with fake identity
endmenu endmenu

4
components/esp_https_ota/src/esp_https_ota.c
View File

@ -36,10 +36,12 @@ esp_err_t esp_https_ota(const esp_http_client_config_t *config)
return ESP_ERR_INVALID_ARG; return ESP_ERR_INVALID_ARG;
} }
#if !CONFIG_OTA_ALLOW_HTTP
if (!config->cert_pem) { if (!config->cert_pem) {
ESP_LOGE(TAG, "Server certificate not found in esp_http_client config"); ESP_LOGE(TAG, "Server certificate not found in esp_http_client config");
return ESP_FAIL; return ESP_FAIL;
} }
#endif
esp_http_client_handle_t client = esp_http_client_init(config); esp_http_client_handle_t client = esp_http_client_init(config);
if (client == NULL) { if (client == NULL) {
@ -47,10 +49,12 @@ esp_err_t esp_https_ota(const esp_http_client_config_t *config)
return ESP_FAIL; return ESP_FAIL;
} }
#if !CONFIG_OTA_ALLOW_HTTP
if (esp_http_client_get_transport_type(client) != HTTP_TRANSPORT_OVER_SSL) { if (esp_http_client_get_transport_type(client) != HTTP_TRANSPORT_OVER_SSL) {
ESP_LOGE(TAG, "Transport is not over HTTPS"); ESP_LOGE(TAG, "Transport is not over HTTPS");
return ESP_FAIL; return ESP_FAIL;
} }
#endif
esp_err_t err = esp_http_client_open(client, 0); esp_err_t err = esp_http_client_open(client, 0);
if (err != ESP_OK) { if (err != ESP_OK) {