aosp/repo
1
0
Fork 0
mirror of https://git.codelinaro.org/clo/tools/repo.git synced 2025-06-01 14:43:34 +08:00
Code Issues Packages Projects Releases Wiki Activity

Make usage of open safer by setting binary mode and closing fds

Browse Source 
Signed-off-by: Shawn O. Pearce <sop@google.com>
This commit is contained in:
Shawn O. Pearce
2009-04-18 14:48:03 -07:00
parent accc56d82b
commit 76ca9f8145
4 changed files with 23 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
git_config.py
View File

@ -219,7 +219,11 @@ class GitConfig(object):
return None
try:
Trace(': unpickle %s', self.file)
return cPickle.load(open(self._pickle, 'r'))
fd = open(self._pickle, 'rb')
try:
return cPickle.load(fd)
finally:
fd.close()
except IOError:
os.remove(self._pickle)
return None
@ -229,9 +233,11 @@ class GitConfig(object):
def _SavePickle(self, cache):
try:
cPickle.dump(cache,
open(self._pickle, 'w'),
cPickle.HIGHEST_PROTOCOL)
fd = open(self._pickle, 'wb')
try:
cPickle.dump(cache, fd, cPickle.HIGHEST_PROTOCOL)
finally:
fd.close()
except IOError:
os.remove(self._pickle)
except cPickle.PickleError: