From 89dee1bd720c4bb9b65a19ea7ab9d3526c0f935d Mon Sep 17 00:00:00 2001 From: Diogo <24511782+diogob003@users.noreply.github.com> Date: Mon, 11 Aug 2025 16:42:03 -0300 Subject: [PATCH] Fix: unclosed file descriptor, bump libs min ver (#1818) * Fix: close inputPFD:ParcelFileDescriptor in AppContextUtils * Security: bump libs minor version --- .gitignore | 5 ----- .vscode/settings.json | 6 ------ .../com/lagradost/cloudstream3/ui/player/PlayerPipHelper.kt | 2 +- .../com/lagradost/cloudstream3/utils/AppContextUtils.kt | 4 +++- gradle/libs.versions.toml | 6 +++--- 5 files changed, 7 insertions(+), 16 deletions(-) delete mode 100644 .vscode/settings.json diff --git a/.gitignore b/.gitignore index a6833cddf..5fc9f0870 100644 --- a/.gitignore +++ b/.gitignore @@ -96,11 +96,6 @@ replay_pid* ### VisualStudioCode ### .vscode/* -!.vscode/settings.json -!.vscode/tasks.json -!.vscode/launch.json -!.vscode/extensions.json -!.vscode/*.code-snippets # Local History for Visual Studio Code .history/ diff --git a/.vscode/settings.json b/.vscode/settings.json deleted file mode 100644 index 7282979ad..000000000 --- a/.vscode/settings.json +++ /dev/null @@ -1,6 +0,0 @@ -{ - "githubPullRequests.ignoredPullRequestBranches": [ - "master" - ], - "java.configuration.updateBuildConfiguration": "interactive" -} \ No newline at end of file diff --git a/app/src/main/java/com/lagradost/cloudstream3/ui/player/PlayerPipHelper.kt b/app/src/main/java/com/lagradost/cloudstream3/ui/player/PlayerPipHelper.kt index cc99b585f..7e9c39b01 100644 --- a/app/src/main/java/com/lagradost/cloudstream3/ui/player/PlayerPipHelper.kt +++ b/app/src/main/java/com/lagradost/cloudstream3/ui/player/PlayerPipHelper.kt @@ -118,4 +118,4 @@ class PlayerPipHelper { } } } -} \ No newline at end of file +} diff --git a/app/src/main/java/com/lagradost/cloudstream3/utils/AppContextUtils.kt b/app/src/main/java/com/lagradost/cloudstream3/utils/AppContextUtils.kt index 28b194531..1c196c5e0 100644 --- a/app/src/main/java/com/lagradost/cloudstream3/utils/AppContextUtils.kt +++ b/app/src/main/java/com/lagradost/cloudstream3/utils/AppContextUtils.kt @@ -967,7 +967,7 @@ object AppContextUtils { //val media = medialibrary.getMedia(data.lastPathSegment!!.toLong()) uri = null//media.uri*/ } else { - val inputPFD: ParcelFileDescriptor? + var inputPFD: ParcelFileDescriptor? = null try { inputPFD = ctx.contentResolver.openFileDescriptor(data, "r") if (inputPFD == null) return data @@ -999,6 +999,8 @@ object AppContextUtils { } catch (e: SecurityException) { Log.e("TAG", "${e.message} for $data", e) return null + } finally { + inputPFD?.close() } }// Media or MMS URI } diff --git a/gradle/libs.versions.toml b/gradle/libs.versions.toml index 1cbb2ef18..7a3fd9165 100644 --- a/gradle/libs.versions.toml +++ b/gradle/libs.versions.toml @@ -1,7 +1,7 @@ [versions] acraCore = "5.12.0" -appcompat = "1.7.0" -biometric = "1.4.0-alpha03" +appcompat = "1.7.1" +biometric = "1.4.0-alpha04" buildkonfigGradlePlugin = "0.15.2" coil = "3.1.0" colorpicker = "6b46b49bd5" @@ -12,7 +12,7 @@ desugar_jdk_libs_nio = "2.1.5" dokkaGradlePlugin = "2.0.0" espressoCore = "3.6.1" fuzzywuzzy = "1.4.0" -gradle = "8.9.2" +gradle = "8.9.3" jacksonModuleKotlin = "2.13.1" json = "20250107" junit = "4.13.2"