From bbfbd2fb724ffda41205d67985b4fecac7874b4c Mon Sep 17 00:00:00 2001 From: Hans-Peter Lehmann Date: Tue, 10 Mar 2026 00:32:51 +0100 Subject: [PATCH] Improve usability of error printer (#8330) ### Description Improve usability of error printer. GitHub shows the first line in the actions output, which in this case was a message talking about XML even if the error is not actually about xml. Swapping them should make it easier to see what is going on. ### Checklist - [x] I have read the contribution guidelines: https://github.com/AntennaPod/AntennaPod/blob/develop/CONTRIBUTING.md#submit-a-pull-request - [x] I have performed a self-review of my code, going through my changes line by line and carefully considering why this line change is necessary - [x] I have run the automated code checks using `./gradlew checkstyle spotbugsPlayDebug spotbugsDebug :app:lintPlayDebug` - [x] My code follows the style guidelines of the AntennaPod project: https://antennapod.org/contribute/develop/app/code-style - [x] I have mentioned the corresponding issue and the relevant keyword (e.g., "Closes: #xy") in the description (see https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue) - [x] If it is a core feature, I have added automated tests --- .github/workflows/checks.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/checks.yml b/.github/workflows/checks.yml index 07c31b94c..5f279000a 100644 --- a/.github/workflows/checks.yml +++ b/.github/workflows/checks.yml @@ -47,8 +47,8 @@ jobs: - name: Generate readable error messages for GitHub if: failure() run: | - git diff --name-only | xargs -I '{}' echo "::error file={},line=1,endLine=1,title=XML Format::Run android-xml-formatter.jar on this file or view CI output to see how it should be formatted." python .github/workflows/errorPrinter.py + git diff --name-only | xargs -I '{}' echo "::error file={},line=1,endLine=1,title=XML Format::Run android-xml-formatter.jar on this file or view CI output to see how it should be formatted." false unit-test: