From dac178e712d91f243ae70a2b268e5bf07d384a09 Mon Sep 17 00:00:00 2001
From: Terence <45381509+Vielheim@users.noreply.github.com>
Date: Fri, 21 Oct 2022 23:14:57 +0800
Subject: [PATCH 1/3] [resumes][fix] fix reply comments (#407)

Co-authored-by: Terence Ho <>
---
 .../resumes/comments/ResumeCommentListItem.tsx | 18 ++++++++++--------
 1 file changed, 10 insertions(+), 8 deletions(-)
diff --git a/apps/portal/src/components/resumes/comments/ResumeCommentListItem.tsx b/apps/portal/src/components/resumes/comments/ResumeCommentListItem.tsx
index 5561a49e..07d951bb 100644
--- a/apps/portal/src/components/resumes/comments/ResumeCommentListItem.tsx
+++ b/apps/portal/src/components/resumes/comments/ResumeCommentListItem.tsx
@@ -96,15 +96,17 @@ export default function ResumeCommentListItem({
           <div className="flex flex-row space-x-1 pt-1 align-middle">
             <ResumeCommentVoteButtons commentId={comment.id} userId={userId} />
 
-            {/* Action buttons; only present when not editing/replying */}
-            {isCommentOwner && !isEditingComment && !isReplyingComment && (
+            {/* Action buttons; only present for authenticated user when not editing/replying */}
+            {userId && !isEditingComment && !isReplyingComment && (
               <>
-                <button
-                  className="px-1 text-xs text-indigo-800 hover:text-indigo-400"
-                  type="button"
-                  onClick={() => setIsEditingComment(true)}>
-                  Edit
-                </button>
+                {isCommentOwner && (
+                  <button
+                    className="px-1 text-xs text-indigo-800 hover:text-indigo-400"
+                    type="button"
+                    onClick={() => setIsEditingComment(true)}>
+                    Edit
+                  </button>
+                )}
 
                 {!comment.parentId && (
                   <button

From 7d0dba966968d9a5f6c15fee769ba03e5e9b633a Mon Sep 17 00:00:00 2001
From: Keane Chan <e0425601@u.nus.edu>
Date: Sat, 22 Oct 2022 00:09:27 +0800
Subject: [PATCH 2/3] [resumes][fix] invalidate fetch query on submit

---
 apps/portal/src/pages/resumes/submit.tsx | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/apps/portal/src/pages/resumes/submit.tsx b/apps/portal/src/pages/resumes/submit.tsx
index 92a1c392..28b7a3b6 100644
--- a/apps/portal/src/pages/resumes/submit.tsx
+++ b/apps/portal/src/pages/resumes/submit.tsx
@@ -80,6 +80,7 @@ export default function SubmitResumeForm({
 
   const { data: session, status } = useSession();
   const router = useRouter();
+  const trpcContext = trpc.useContext();
   const resumeUpsertMutation = trpc.useMutation('resumes.resume.user.upsert');
   const isNewForm = initFormDetails == null;
 
@@ -170,6 +171,7 @@ export default function SubmitResumeForm({
         },
         onSuccess() {
           if (isNewForm) {
+            trpcContext.invalidateQueries('resumes.resume.findAll');
             router.push('/resumes/browse');
           } else {
             onClose();
@@ -228,7 +230,7 @@ export default function SubmitResumeForm({
       <Head>
         <title>Upload a Resume</title>
       </Head>
-      <main className="h-[calc(100vh-4rem)] flex-1 overflow-y-scroll">
+      <main className="h-[calc(100vh-4rem)] flex-1 overflow-y-auto">
         <section
           aria-labelledby="primary-heading"
           className="flex h-full min-w-0 flex-1 flex-col lg:order-last">

From 2414deb62452aa15e57ef09837287db39214c6a3 Mon Sep 17 00:00:00 2001
From: Keane Chan <e0425601@u.nus.edu>
Date: Sat, 22 Oct 2022 00:09:48 +0800
Subject: [PATCH 3/3] [resumes][feat] use overflow-auto instead

---
 apps/portal/src/pages/resumes/browse.tsx | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/apps/portal/src/pages/resumes/browse.tsx b/apps/portal/src/pages/resumes/browse.tsx
index 84b118fd..af1cae93 100644
--- a/apps/portal/src/pages/resumes/browse.tsx
+++ b/apps/portal/src/pages/resumes/browse.tsx
@@ -361,7 +361,7 @@ export default function ResumeHomePage() {
         </Transition.Root>
       </div>
 
-      <main className="h-[calc(100vh-4rem)] flex-1 overflow-y-scroll">
+      <main className="h-[calc(100vh-4rem)] flex-1 overflow-y-auto">
         <div className="ml-4 py-4">
           <ResumeReviewsTitle />
         </div>
