algorithm/tech-interview-handbook
1
0
Fork 0
mirror of https://github.com/yangshun/tech-interview-handbook.git synced 2025-08-01 17:35:08 +08:00
Code Issues Packages Projects Releases Wiki Activity

[app/portal][fix] Add tab redirection (#365)

Browse Source 
* [app/portal][fix] Add new tab redirection to navigation items with target:_blank

* [app/portal][fix] Fix rel and typos

Co-authored-by: Terence Ho <>
This commit is contained in:
Terence
2022-10-12 13:08:42 +08:00
committed by GitHub
parent d59da5d186
commit daee770519
1 changed files with 16 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
apps/portal/src/components/global/ProductNavigation.tsx
View File

@ -4,6 +4,7 @@ import { useRouter } from 'next/router';
import { Fragment } from 'react';
import { Menu, Transition } from '@headlessui/react';
import { ChevronDownIcon } from '@heroicons/react/20/solid';
import { ArrowTopRightOnSquareIcon } from '@heroicons/react/24/outline';
type NavigationItem = Readonly<{
children?: ReadonlyArray<NavigationItem>;
@ -58,7 +59,13 @@ export default function ProductNavigation({ items, title, titleHref }: Props) {
active ? 'bg-slate-100' : '',
'block px-4 py-2 text-sm text-slate-700',
)}
href={child.href}>
href={child.href}
rel={
!child.href.startsWith('/')
? 'noopener noreferrer'
: undefined
}
target={child.target}>
{child.name}
</Link>
)}
@ -75,8 +82,15 @@ export default function ProductNavigation({ items, title, titleHref }: Props) {
'hover:text-primary-600 inline-flex h-full items-center border-y-2 border-t-transparent text-sm font-medium text-slate-900',
isActive ? 'border-b-primary-500' : 'border-b-transparent',
)}
href={item.href}>
href={item.href}
rel={
!item.href.startsWith('/') ? 'noopener noreferrer' : undefined
}
target={item.target}>
{item.name}
{item.target ? (
<ArrowTopRightOnSquareIcon className="h-5 w-5 pl-1" />
) : null}
</Link>
);
})}