algorithm/tech-interview-handbook
1
0
Fork 0
mirror of https://github.com/yangshun/tech-interview-handbook.git synced 2025-07-28 20:52:00 +08:00
Code Issues Packages Projects Releases Wiki Activity

[offers][chore] Add error handling to list offers API

Browse Source
This commit is contained in:
BryannYeap
2022-10-14 05:45:39 +08:00
parent 5034a4dace
commit 6c41118785
1 changed files with 35 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

45
apps/portal/src/server/router/offers/offers.ts
View File

@ -1,5 +1,5 @@
import assert from 'assert';
import { z } from 'zod';
import { TRPCError } from '@trpc/server';
import { createRouter } from '../context';
@ -227,7 +227,12 @@ export const offersRouter = createRouter().query('list', {
? offer.OffersFullTime?.totalCompensation.value
: offer.OffersIntern?.monthlySalary.value;
assert(salary);
if (!salary) {
throw new TRPCError({
code: 'NOT_FOUND',
message: 'Total Compensation or Salary not found',
});
}
validRecord =
validRecord && salary >= input.salaryMin && salary <= input.salaryMax;
@ -266,18 +271,28 @@ export const offersRouter = createRouter().query('list', {
? offer2.OffersFullTime?.totalCompensation.value
: offer2.OffersIntern?.monthlySalary.value;
if (salary1 && salary2) {
return salary1 - salary2;
if (!salary1 || !salary2) {
throw new TRPCError({
code: 'NOT_FOUND',
message: 'Total Compensation or Salary not found',
});
}
return salary1 - salary2;
}
if (sortingKey === 'totalYoe') {
const yoe1 = offer1.profile.background?.totalYoe;
const yoe2 = offer2.profile.background?.totalYoe;
if (yoe1 && yoe2) {
return yoe1 - yoe2;
if (!yoe1 || !yoe2) {
throw new TRPCError({
code: 'NOT_FOUND',
message: 'Total years of experience not found',
});
}
return yoe1 - yoe2;
}
return defaultReturn;
@ -302,18 +317,28 @@ export const offersRouter = createRouter().query('list', {
? offer2.OffersFullTime?.totalCompensation.value
: offer2.OffersIntern?.monthlySalary.value;
if (salary1 && salary2) {
return salary2 - salary1;
if (!salary1 || !salary2) {
throw new TRPCError({
code: 'NOT_FOUND',
message: 'Total Compensation or Salary not found',
});
}
return salary2 - salary1;
}
if (sortingKey === 'totalYoe') {
const yoe1 = offer1.profile.background?.totalYoe;
const yoe2 = offer2.profile.background?.totalYoe;
if (yoe1 && yoe2) {
return yoe2 - yoe1;
if (!yoe1 || !yoe2) {
throw new TRPCError({
code: 'NOT_FOUND',
message: 'Total years of experience not found',
});
}
return yoe2 - yoe1;
}
return defaultReturn;