From 510e3d3227e817c99b2f8e3f85ca345dd8a3fbf5 Mon Sep 17 00:00:00 2001
From: Keane Chan <e0425601@u.nus.edu>
Date: Sat, 15 Oct 2022 11:07:10 +0800
Subject: [PATCH] [resumes][chore] remove resumeFile state

---
 apps/portal/src/pages/resumes/submit.tsx | 13 +++----------
 1 file changed, 3 insertions(+), 10 deletions(-)

diff --git a/apps/portal/src/pages/resumes/submit.tsx b/apps/portal/src/pages/resumes/submit.tsx
index d64c7d6c..471cd511 100644
--- a/apps/portal/src/pages/resumes/submit.tsx
+++ b/apps/portal/src/pages/resumes/submit.tsx
@@ -79,7 +79,6 @@ export default function SubmitResumeForm({
   initFormDetails,
   onClose = () => undefined,
 }: Props) {
-  const [resumeFile, setResumeFile] = useState<File | null>(null);
   const [isLoading, setIsLoading] = useState(false);
   const [invalidFileUploadError, setInvalidFileUploadError] = useState<
     string | null
@@ -96,6 +95,7 @@ export default function SubmitResumeForm({
     handleSubmit,
     setValue,
     reset,
+    watch,
     formState: { errors, isDirty, dirtyFields },
   } = useForm<IFormInput>({
     defaultValues: {
@@ -104,11 +104,12 @@ export default function SubmitResumeForm({
     },
   });
 
+  const resumeFile = watch('file');
+
   const onFileDrop = useCallback(
     (acceptedFiles: Array<File>, fileRejections: Array<FileRejection>) => {
       if (fileRejections.length === 0) {
         setInvalidFileUploadError('');
-        setResumeFile(acceptedFiles[0]);
         setValue('file', acceptedFiles[0], {
           shouldDirty: true,
         });
@@ -147,7 +148,6 @@ export default function SubmitResumeForm({
     const fileName = keyAndFileName.substring(keyAndFileName.indexOf('-') + 1);
 
     const file = new File([data], fileName);
-    setResumeFile(file);
     setValue('file', file, {
       shouldDirty: false,
     });
@@ -168,9 +168,6 @@ export default function SubmitResumeForm({
   }, [fetchFilePdf]);
 
   const onSubmit: SubmitHandler<IFormInput> = async (data) => {
-    if (resumeFile == null) {
-      return;
-    }
     setIsLoading(true);
     let fileUrl = initFormDetails?.url ?? '';
 
@@ -228,16 +225,12 @@ export default function SubmitResumeForm({
     onClose();
     setIsDialogShown(false);
     reset();
-    setResumeFile(null);
     setInvalidFileUploadError(null);
   };
 
   const onClickDownload = async (
     event: React.MouseEvent<HTMLParagraphElement, MouseEvent>,
   ) => {
-    if (resumeFile == null) {
-      return;
-    }
     // Prevent click event from propagating up to dropzone
     event.stopPropagation();