algorithm/tech-interview-handbook
1
0
Fork 0
mirror of https://github.com/yangshun/tech-interview-handbook.git synced 2025-07-15 02:33:50 +08:00
Code Issues Packages Projects Releases Wiki Activity

[ui][select] make uncontrolled

Browse Source
This commit is contained in:
Yangshun Tay
2022-10-06 09:35:52 +08:00
parent 1f640fda5e
commit 1df0ce35a6
2 changed files with 32 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
packages/ui/src/Select/Select.tsx
View File

@ -16,18 +16,20 @@ export type SelectItem<T> = Readonly<{
export type SelectDisplay = 'block' | 'inline';
type Props<T> = Readonly<{
defaultValue?: T;
display?: SelectDisplay;
isLabelHidden?: boolean;
label: string;
name?: string;
onChange: (value: string) => void;
onChange?: (value: string) => void;
options: ReadonlyArray<SelectItem<T>>;
value: T;
value?: T;
}> &
Readonly<Attributes>;
function Select<T>(
{
defaultValue,
display,
disabled,
label,
@ -59,11 +61,12 @@ function Select<T>(
'focus:border-primary-500 focus:ring-primary-500 rounded-md border-slate-300 py-2 pl-3 pr-10 text-base focus:outline-none sm:text-sm',
disabled && 'bg-slate-100',
)}
defaultValue={defaultValue != null ? String(defaultValue) : undefined}
disabled={disabled}
id={id}
value={String(value)}
value={value != null ? String(value) : undefined}
onChange={(event) => {
onChange(event.target.value);
onChange?.(event.target.value);
}}
{...props}>
{options.map(({ label: optionLabel, value: optionValue }) => (