algorithm/hello-algo
1
0
Fork 0
mirror of https://github.com/krahets/hello-algo.git synced 2025-07-28 04:42:48 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fix rust compile warning and an obvious print error in array.rs (#1144)

Browse Source 
* Fix rust compile warning and an obvious print error in array.rs

* Update LinkedList

1. drop unnessaray mut borrow
2. fmt code and make variable more readable

* follow convention of this repo

* Update list_node.rs

---------

Co-authored-by: Yudong Jin <krahets@163.com>
This commit is contained in:
rongyi
2024-03-18 02:44:03 +08:00
committed by GitHub
parent 7b1094318b
commit 6f1ec66949
4 changed files with 15 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
codes/rust/include/list_node.rs
View File

@ -1,12 +1,12 @@
/*
* File: list_node.rs
* Created Time: 2023-03-05
* Author: codingonion (coderonion@gmail.com)
* Author: codingonion (coderonion@gmail.com), rongyi (hiarongyi@gmail.com)
*/
use std::rc::Rc;
use std::cell::RefCell;
use std::collections::HashMap;
use std::rc::Rc;
#[derive(Debug)]
pub struct ListNode<T> {
@ -16,25 +16,21 @@ pub struct ListNode<T> {
impl<T> ListNode<T> {
pub fn new(val: T) -> Rc<RefCell<ListNode<T>>> {
Rc::new(RefCell::new(ListNode {
val,
next: None,
}))
Rc::new(RefCell::new(ListNode { val, next: None }))
}
/* Generate a linked list with an array */
pub fn arr_to_linked_list(array: &[T]) -> Option<Rc<RefCell<ListNode<T>>>>
pub fn arr_to_linked_list(array: &[T]) -> Option<Rc<RefCell<ListNode<T>>>>
where
T: Copy + Clone,
{
let mut head = None;
let mut prev = None;
// insert in reverse order
for item in array.iter().rev() {
let node = Rc::new(RefCell::new(ListNode {
val: *item,
next: prev.take(),
next: head.clone(),
}));
prev = Some(node.clone());
head = Some(node);
}
head
@ -43,9 +39,9 @@ impl<T> ListNode<T> {
/* Generate a hashmap with a linked_list */
pub fn linked_list_to_hashmap(
linked_list: Option<Rc<RefCell<ListNode<T>>>>,
) -> HashMap<T, Rc<RefCell<ListNode<T>>>>
) -> HashMap<T, Rc<RefCell<ListNode<T>>>>
where
T: std::hash::Hash + Eq + Copy + Clone
T: std::hash::Hash + Eq + Copy + Clone,
{
let mut hashmap = HashMap::new();
if let Some(node) = linked_list {