From bb5552efd0fea2a8e83aef4321d9686acb150b59 Mon Sep 17 00:00:00 2001
From: mateuszz0000 <mtszzwdzk@gmail.com>
Date: Mon, 25 May 2020 12:32:57 +0200
Subject: [PATCH] Euclidean recursive method + doctests + type hints (#1999)

* Recursive euclidean algorithm + doctests and type hints

* Fix doctests in recursive method

* Added commit suggestions
---
 other/euclidean_gcd.py | 46 +++++++++++++++++++++++++++++++++---------
 1 file changed, 36 insertions(+), 10 deletions(-)

diff --git a/other/euclidean_gcd.py b/other/euclidean_gcd.py
index c6c11f947..de4b25024 100644
--- a/other/euclidean_gcd.py
+++ b/other/euclidean_gcd.py
@@ -1,20 +1,46 @@
-# https://en.wikipedia.org/wiki/Euclidean_algorithm
+""" https://en.wikipedia.org/wiki/Euclidean_algorithm """
 
 
-def euclidean_gcd(a, b):
+def euclidean_gcd(a: int, b: int) -> int:
+    """
+    Examples:
+    >>> euclidean_gcd(3, 5)
+    1
+
+    >>> euclidean_gcd(6, 3)
+    3
+    """
     while b:
-        t = b
-        b = a % b
-        a = t
+        a, b = b, a % b
     return a
 
 
+def euclidean_gcd_recursive(a: int, b: int) -> int:
+    """
+    Recursive method for euclicedan gcd algorithm
+
+    Examples:
+    >>> euclidean_gcd_recursive(3, 5)
+    1
+
+    >>> euclidean_gcd_recursive(6, 3)
+    3
+    """
+    return a if b == 0 else euclidean_gcd_recursive(b, a % b)
+
+
 def main():
-    print("GCD(3, 5) = " + str(euclidean_gcd(3, 5)))
-    print("GCD(5, 3) = " + str(euclidean_gcd(5, 3)))
-    print("GCD(1, 3) = " + str(euclidean_gcd(1, 3)))
-    print("GCD(3, 6) = " + str(euclidean_gcd(3, 6)))
-    print("GCD(6, 3) = " + str(euclidean_gcd(6, 3)))
+    print(f"euclidean_gcd(3, 5) = {euclidean_gcd(3, 5)}")
+    print(f"euclidean_gcd(5, 3) = {euclidean_gcd(5, 3)}")
+    print(f"euclidean_gcd(1, 3) = {euclidean_gcd(1, 3)}")
+    print(f"euclidean_gcd(3, 6) = {euclidean_gcd(3, 6)}")
+    print(f"euclidean_gcd(6, 3) = {euclidean_gcd(6, 3)}")
+
+    print(f"euclidean_gcd_recursive(3, 5) = {euclidean_gcd_recursive(3, 5)}")
+    print(f"euclidean_gcd_recursive(5, 3) = {euclidean_gcd_recursive(5, 3)}")
+    print(f"euclidean_gcd_recursive(1, 3) = {euclidean_gcd_recursive(1, 3)}")
+    print(f"euclidean_gcd_recursive(3, 6) = {euclidean_gcd_recursive(3, 6)}")
+    print(f"euclidean_gcd_recursive(6, 3) = {euclidean_gcd_recursive(6, 3)}")
 
 
 if __name__ == "__main__":