Fix some warnings from LGTM (#2420)

* fix assignment of a variable to itself

* Fix unnecessary 'else' clause in loop

* formatting and redundant reasignment fix

* mark unreachable code with a TODO comment

* fix variable defined multiple times

* fix static method without static decorator

* revert unintended autoformatting

Co-authored-by: Christian Clauss <cclauss@me.com>

* revert autoformatting issue

* applied black autoformatting

Co-authored-by: Christian Clauss <cclauss@me.com>
This commit is contained in:
Hasenn
2020-09-13 10:11:27 +02:00
committed by GitHub
parent f754c0d31f
commit 20e98fcded
6 changed files with 9 additions and 6 deletions

View File

@@ -226,6 +226,7 @@ class DirectedGraph:
break
else:
return True
# TODO:The following code is unreachable.
anticipating_nodes.add(stack[len_stack_minus_one])
len_stack_minus_one -= 1
if visited.count(node[1]) < 1:
@@ -453,6 +454,8 @@ class Graph:
break
else:
return True
# TODO: the following code is unreachable
# is this meant to be called in the else ?
anticipating_nodes.add(stack[len_stack_minus_one])
len_stack_minus_one -= 1
if visited.count(node[1]) < 1:

View File

@@ -146,6 +146,7 @@ class Graph:
self.parent[root2] = root1
return root1
@staticmethod
def boruvka_mst(graph):
"""
Implementation of Boruvka's algorithm