algorithm/JavaScript
1
0
Fork 0
mirror of https://github.com/TheAlgorithms/JavaScript.git synced 2025-07-04 15:39:42 +08:00
Code Issues Packages Projects Releases Wiki Activity

merge: Edit Perfect{Square, Cube} (#1071)

Browse Source 
* Make `PerfectCube` more correct and readable

* Add negative and Infinity tests

* Fixed comment formatting

* Realized BigInt support is unnecessary

The algorithm would be exactly the same, so there's no added educational value

* Update PerfectCube.js

* Remove space

* Update PerfectCube.js

Now `isInt` is replaced by `isFinite`, because `isInt` is a redundant check

* Update PerfectCube.js

Remove dot

* Parity between `PerfectSquare` and `PerfectCube`

* Update PerfectSquare.test.js

Fixed the old copy-paste error that said "cube" instead of "square". And added `Infinity` test
This commit is contained in:
Ricardo Fernández Serrata
2022-08-12 13:44:25 -04:00
committed by GitHub
parent e9b8b136b9
commit 979046897d
4 changed files with 9 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
Maths/PerfectCube.js
View File

@ -2,8 +2,9 @@
* Author: dephraiim * Author: dephraiim
* License: GPL-3.0 or later * License: GPL-3.0 or later
* *
* This uses `round` instead of `floor` or `trunc`, to guard against potential `cbrt` accuracy errors
*/ */
const perfectCube = (num) => Math.round(num ** (1 / 3)) ** 3 === num const perfectCube = (num) => Number.isFinite(num) && Math.round(Math.cbrt(num)) ** 3 === num
export { perfectCube } export { perfectCube }

3
Maths/PerfectSquare.js
View File

@ -2,8 +2,9 @@
* Author: dephraiim * Author: dephraiim
* License: GPL-3.0 or later * License: GPL-3.0 or later
* *
* This uses `round` instead of `floor` or `trunc`, to guard against potential `sqrt` accuracy errors
*/ */
const perfectSquare = (num) => Math.sqrt(num) ** 2 === num const perfectSquare = (num) => Number.isFinite(num) && Math.round(Math.sqrt(num)) ** 2 === num
export { perfectSquare } export { perfectSquare }

2
Maths/test/PerfectCube.test.js
View File

@ -3,8 +3,10 @@ import { perfectCube } from '../PerfectCube'
describe('PerfectCube', () => { describe('PerfectCube', () => {
it('should return true for a perfect cube', () => { it('should return true for a perfect cube', () => {
expect(perfectCube(125)).toBeTruthy() expect(perfectCube(125)).toBeTruthy()
expect(perfectCube(-125)).toBeTruthy()
}) })
it('should return false for a non perfect cube', () => { it('should return false for a non perfect cube', () => {
expect(perfectCube(100)).toBeFalsy() expect(perfectCube(100)).toBeFalsy()
expect(perfectCube(Infinity)).toBeFalsy()
}) })
}) })

5
Maths/test/PerfectSquare.test.js
View File

@ -1,10 +1,11 @@
import { perfectSquare } from '../PerfectSquare' import { perfectSquare } from '../PerfectSquare'
describe('PerfectSquare', () => { describe('PerfectSquare', () => {
it('should return true for a perfect cube', () => { it('should return true for a perfect square', () => {
expect(perfectSquare(16)).toBeTruthy() expect(perfectSquare(16)).toBeTruthy()
}) })
it('should return false for a non perfect cube', () => { it('should return false for a non perfect square', () => {
expect(perfectSquare(10)).toBeFalsy() expect(perfectSquare(10)).toBeFalsy()
expect(perfectSquare(Infinity)).toBeFalsy()
}) })
}) })