merge: Optimize the space complexity of the fibonacci algo (#899)

* docs: update js doc

* feat: add number type validation condition

* pref: Optimize space complexity

remove the Array from the algo and used two flag varible to calculate last two numbers & optimize the sapce complexity O(n) to O(1)

* test: add test case for invalid types
This commit is contained in:
Fahim Faisaal
2022-02-22 16:50:46 +06:00
committed by GitHub
parent 743b3179f7
commit 8bf29fe17c
2 changed files with 23 additions and 9 deletions

View File

@ -1,19 +1,27 @@
/**
* @function Fibonacci
* @function fibonacci
* @description Fibonacci is the sum of previous two fibonacci numbers.
* @param {Integer} N - The input integer
* @return {Integer} fibonacci of N.
* @see [Fibonacci_Numbers](https://en.wikipedia.org/wiki/Fibonacci_number)
*/
const fibonacci = (N) => {
// creating array to store values
const memo = new Array(N + 1)
memo[0] = 0
memo[1] = 1
for (let i = 2; i <= N; i++) {
memo[i] = memo[i - 1] + memo[i - 2]
if (!Number.isInteger(N)) {
throw new TypeError('Input should be integer')
}
return memo[N]
// memoize the last two numbers
let firstNumber = 0
let secondNumber = 1
for (let i = 1; i < N; i++) {
const sumOfNumbers = firstNumber + secondNumber
// update last two numbers
firstNumber = secondNumber
secondNumber = sumOfNumbers
}
return N ? secondNumber : firstNumber
}
export { fibonacci }