From 7ab9792f16b1c2f828194f6d4aa1ed39aca74a13 Mon Sep 17 00:00:00 2001
From: k ho k ho? <6939499+kho-kho-kho@users.noreply.github.com>
Date: Thu, 22 Sep 2022 04:54:29 -0700
Subject: [PATCH] algorithm: Iterative (and in-place) BFS for binary trees
 (#1102)

* Bugfix AVLTree comparator

The original insertBalance function was doing raw value comparisons as opposed to using the tree's comparator. This is clearly unintentional, and would (ultimately) cause the structure to segfault when constructed with the stringData included in the updated test.

I've added the fix, scanned the rest of the code for similar issues, and added the appropriate test case which passes successfully with the fix. The jest code coverage increases slightly as well with the changes.

* 100% jest code coverage

Added a couple of extra elements to the original test tree, and then removed elements in an order such that all previously uncovered branches of code are now covered.

Also added an emptyTree structure to test some additional (trivial) base cases.

* standard style fix

missed this from my previous commit

* Iterative & in-place BFS

An iterative analog to the traditional recursive breadth-first-search algorithm for binary trees.

This in-place solution uses the pre-existing "traversal" array for both tracking the algorithm as well as storing the result.

Also tweaked old code by resetting the traversal array each time the tree is traversed (otherwise you're only allowed to traverse a tree once which doesn't seem correct even with a single traversal function).

* Update BreadthFirstTreeTraversal.js

got rid of unnecessary currentSize
added currentNode for clarity
---
 Trees/BreadthFirstTreeTraversal.js           | 21 +++++++++++++++++++-
 Trees/test/BreadthFirstTreeTraversal.test.js |  9 +++++++--
 2 files changed, 27 insertions(+), 3 deletions(-)

diff --git a/Trees/BreadthFirstTreeTraversal.js b/Trees/BreadthFirstTreeTraversal.js
index 0b4520612..10fdc0aeb 100644
--- a/Trees/BreadthFirstTreeTraversal.js
+++ b/Trees/BreadthFirstTreeTraversal.js
@@ -17,7 +17,26 @@ class BinaryTree {
     this.traversal = []
   }
 
-  breadthFirst () {
+  breadthFirstIterative () {
+    this.traversal = []
+    if (this.root) {
+      this.traversal.push(this.root)
+    }
+    for (let i = 0; i < this.traversal.length; i++) {
+      const currentNode = this.traversal[i]
+      if (currentNode.left) {
+        this.traversal.push(currentNode.left)
+      }
+      if (currentNode.right) {
+        this.traversal.push(currentNode.right)
+      }
+      this.traversal[i] = currentNode.data
+    }
+    return this.traversal
+  }
+
+  breadthFirstRecursive () {
+    this.traversal = []
     const h = this.getHeight(this.root)
     for (let i = 0; i !== h; i++) {
       this.traverseLevel(this.root, i)
diff --git a/Trees/test/BreadthFirstTreeTraversal.test.js b/Trees/test/BreadthFirstTreeTraversal.test.js
index 8e325e02d..a6b795f31 100644
--- a/Trees/test/BreadthFirstTreeTraversal.test.js
+++ b/Trees/test/BreadthFirstTreeTraversal.test.js
@@ -19,9 +19,14 @@ describe('Breadth First Tree Traversal', () => {
   //         / \   \
   //        3   6   9
 
-  it('Binary tree - Level order traversal', () => {
+  it('Binary tree - Level order recursive traversal', () => {
     expect(binaryTree.traversal).toStrictEqual([])
-    const traversal = binaryTree.breadthFirst()
+    const traversal = binaryTree.breadthFirstRecursive()
+    expect(traversal).toStrictEqual([7, 5, 8, 3, 6, 9])
+  })
+
+  it('Binary tree - Level order iterative traversal', () => {
+    const traversal = binaryTree.breadthFirstIterative()
     expect(traversal).toStrictEqual([7, 5, 8, 3, 6, 9])
   })
 })