From f7bd7682ba54d3e6fa93d5c80e9ae8b287d95f9c Mon Sep 17 00:00:00 2001
From: Ankush Banik <86042508+Ankush263@users.noreply.github.com>
Date: Fri, 8 Jul 2022 17:01:09 +0530
Subject: [PATCH] Update Combinations.java and add test case (#3184)

---
 .../com/thealgorithms/maths/Combinations.java | 17 -----------
 .../thealgorithms/maths/CombinationsTest.java | 30 +++++++++++++++++++
 2 files changed, 30 insertions(+), 17 deletions(-)
 create mode 100644 src/test/java/com/thealgorithms/maths/CombinationsTest.java

diff --git a/src/main/java/com/thealgorithms/maths/Combinations.java b/src/main/java/com/thealgorithms/maths/Combinations.java
index eee9b9fc8..34b324466 100644
--- a/src/main/java/com/thealgorithms/maths/Combinations.java
+++ b/src/main/java/com/thealgorithms/maths/Combinations.java
@@ -5,23 +5,6 @@ package com.thealgorithms.maths;
  */
 public class Combinations {
 
-    public static void main(String[] args) {
-        assert combinations(1, 1) == 1;
-        assert combinations(10, 5) == 252;
-        assert combinations(6, 3) == 20;
-        assert combinations(20, 5) == 15504;
-
-        // Since, 200 is a big number its factorial will go beyond limits of long even when 200C5 can be saved in a long
-        // variable. So below will fail
-        // assert combinations(200, 5) == 2535650040l;
-        assert combinationsOptimized(100, 0) == 1;
-        assert combinationsOptimized(1, 1) == 1;
-        assert combinationsOptimized(10, 5) == 252;
-        assert combinationsOptimized(6, 3) == 20;
-        assert combinationsOptimized(20, 5) == 15504;
-        assert combinationsOptimized(200, 5) == 2535650040l;
-    }
-
     /**
      * Calculate of factorial
      *
diff --git a/src/test/java/com/thealgorithms/maths/CombinationsTest.java b/src/test/java/com/thealgorithms/maths/CombinationsTest.java
new file mode 100644
index 000000000..0bcefb7de
--- /dev/null
+++ b/src/test/java/com/thealgorithms/maths/CombinationsTest.java
@@ -0,0 +1,30 @@
+package com.thealgorithms.maths;
+
+import org.junit.jupiter.api.Test;
+
+import static org.junit.jupiter.api.Assertions.assertEquals;
+
+public class CombinationsTest {
+
+    @Test
+    void testCombination() {
+
+        assertEquals(1, Combinations.combinations(1, 1));
+        assertEquals(252, Combinations.combinations(10, 5));
+        assertEquals(20, Combinations.combinations(6, 3));
+        assertEquals(15504, Combinations.combinations(20, 5));
+
+    }
+
+    @Test
+    void testCombinationOptimised() {
+
+        assertEquals(100, Combinations.combinationsOptimized(100, 1));
+        assertEquals(1, Combinations.combinationsOptimized(1, 1));
+        assertEquals(252, Combinations.combinationsOptimized(10, 5));
+        assertEquals(20, Combinations.combinationsOptimized(6, 3));
+        assertEquals(15504, Combinations.combinationsOptimized(20, 5));
+        assertEquals(2535650040L, Combinations.combinationsOptimized(200, 5));
+
+    }
+}