Enhance comments & improve readability in LongestCommonSubsequence.java (#5523)

This commit is contained in:
Hardik Pawar
2024-10-05 18:13:42 +05:30
committed by GitHub
parent 339027388e
commit f34fe4d840
3 changed files with 136 additions and 21 deletions

View File

@ -747,6 +747,7 @@
* [LevenshteinDistanceTests](https://github.com/TheAlgorithms/Java/blob/master/src/test/java/com/thealgorithms/dynamicprogramming/LevenshteinDistanceTests.java) * [LevenshteinDistanceTests](https://github.com/TheAlgorithms/Java/blob/master/src/test/java/com/thealgorithms/dynamicprogramming/LevenshteinDistanceTests.java)
* [LongestAlternatingSubsequenceTest](https://github.com/TheAlgorithms/Java/blob/master/src/test/java/com/thealgorithms/dynamicprogramming/LongestAlternatingSubsequenceTest.java) * [LongestAlternatingSubsequenceTest](https://github.com/TheAlgorithms/Java/blob/master/src/test/java/com/thealgorithms/dynamicprogramming/LongestAlternatingSubsequenceTest.java)
* [LongestArithmeticSubsequenceTest](https://github.com/TheAlgorithms/Java/blob/master/src/test/java/com/thealgorithms/dynamicprogramming/LongestArithmeticSubsequenceTest.java) * [LongestArithmeticSubsequenceTest](https://github.com/TheAlgorithms/Java/blob/master/src/test/java/com/thealgorithms/dynamicprogramming/LongestArithmeticSubsequenceTest.java)
* [LongestCommonSubsequenceTest](https://github.com/TheAlgorithms/Java/blob/master/src/test/java/com/thealgorithms/dynamicprogramming/LongestCommonSubsequenceTest.java)
* [LongestIncreasingSubsequenceTests](https://github.com/TheAlgorithms/Java/blob/master/src/test/java/com/thealgorithms/dynamicprogramming/LongestIncreasingSubsequenceTests.java) * [LongestIncreasingSubsequenceTests](https://github.com/TheAlgorithms/Java/blob/master/src/test/java/com/thealgorithms/dynamicprogramming/LongestIncreasingSubsequenceTests.java)
* [LongestPalindromicSubstringTest](https://github.com/TheAlgorithms/Java/blob/master/src/test/java/com/thealgorithms/dynamicprogramming/LongestPalindromicSubstringTest.java) * [LongestPalindromicSubstringTest](https://github.com/TheAlgorithms/Java/blob/master/src/test/java/com/thealgorithms/dynamicprogramming/LongestPalindromicSubstringTest.java)
* [LongestValidParenthesesTest](https://github.com/TheAlgorithms/Java/blob/master/src/test/java/com/thealgorithms/dynamicprogramming/LongestValidParenthesesTest.java) * [LongestValidParenthesesTest](https://github.com/TheAlgorithms/Java/blob/master/src/test/java/com/thealgorithms/dynamicprogramming/LongestValidParenthesesTest.java)

View File

@ -1,73 +1,98 @@
package com.thealgorithms.dynamicprogramming; package com.thealgorithms.dynamicprogramming;
/**
* This class implements the Longest Common Subsequence (LCS) problem.
* The LCS of two sequences is the longest sequence that appears in both
* sequences
* in the same order, but not necessarily consecutively.
*
* This implementation uses dynamic programming to find the LCS of two strings.
*/
final class LongestCommonSubsequence { final class LongestCommonSubsequence {
private LongestCommonSubsequence() { private LongestCommonSubsequence() {
} }
/**
* Returns the Longest Common Subsequence (LCS) of two given strings.
*
* @param str1 The first string.
* @param str2 The second string.
* @return The LCS of the two strings, or null if one of the strings is null.
*/
public static String getLCS(String str1, String str2) { public static String getLCS(String str1, String str2) {
// At least one string is null // If either string is null, return null as LCS can't be computed.
if (str1 == null || str2 == null) { if (str1 == null || str2 == null) {
return null; return null;
} }
// If either string is empty, return an empty string as LCS.
// At least one string is empty
if (str1.length() == 0 || str2.length() == 0) { if (str1.length() == 0 || str2.length() == 0) {
return ""; return "";
} }
// Convert the strings into arrays of characters
String[] arr1 = str1.split(""); String[] arr1 = str1.split("");
String[] arr2 = str2.split(""); String[] arr2 = str2.split("");
// lcsMatrix[i][j] = LCS of first i elements of arr1 and first j characters of arr2 // lcsMatrix[i][j] = LCS(first i characters of str1, first j characters of str2)
int[][] lcsMatrix = new int[arr1.length + 1][arr2.length + 1]; int[][] lcsMatrix = new int[arr1.length + 1][arr2.length + 1];
// Base Case: Fill the LCS matrix 0th row & 0th column with 0s
// as LCS of any string with an empty string is 0.
for (int i = 0; i < arr1.length + 1; i++) { for (int i = 0; i < arr1.length + 1; i++) {
lcsMatrix[i][0] = 0; lcsMatrix[i][0] = 0;
} }
for (int j = 1; j < arr2.length + 1; j++) { for (int j = 1; j < arr2.length + 1; j++) {
lcsMatrix[0][j] = 0; lcsMatrix[0][j] = 0;
} }
// Build the LCS matrix by comparing characters of str1 & str2
for (int i = 1; i < arr1.length + 1; i++) { for (int i = 1; i < arr1.length + 1; i++) {
for (int j = 1; j < arr2.length + 1; j++) { for (int j = 1; j < arr2.length + 1; j++) {
// If characters match, the LCS increases by 1
if (arr1[i - 1].equals(arr2[j - 1])) { if (arr1[i - 1].equals(arr2[j - 1])) {
lcsMatrix[i][j] = lcsMatrix[i - 1][j - 1] + 1; lcsMatrix[i][j] = lcsMatrix[i - 1][j - 1] + 1;
} else { } else {
// Otherwise, take the maximum of the left or above values
lcsMatrix[i][j] = Math.max(lcsMatrix[i - 1][j], lcsMatrix[i][j - 1]); lcsMatrix[i][j] = Math.max(lcsMatrix[i - 1][j], lcsMatrix[i][j - 1]);
} }
} }
} }
// Call helper function to reconstruct the LCS from the matrix
return lcsString(str1, str2, lcsMatrix); return lcsString(str1, str2, lcsMatrix);
} }
/**
* Reconstructs the LCS string from the LCS matrix.
*
* @param str1 The first string.
* @param str2 The second string.
* @param lcsMatrix The matrix storing the lengths of LCSs
* of substrings of str1 and str2.
* @return The LCS string.
*/
public static String lcsString(String str1, String str2, int[][] lcsMatrix) { public static String lcsString(String str1, String str2, int[][] lcsMatrix) {
StringBuilder lcs = new StringBuilder(); StringBuilder lcs = new StringBuilder(); // Hold the LCS characters.
int i = str1.length(); int i = str1.length(); // Start from the end of str1.
int j = str2.length(); int j = str2.length(); // Start from the end of str2.
// Trace back through the LCS matrix to reconstruct the LCS
while (i > 0 && j > 0) { while (i > 0 && j > 0) {
// If characters match, add to the LCS and move diagonally in the matrix
if (str1.charAt(i - 1) == str2.charAt(j - 1)) { if (str1.charAt(i - 1) == str2.charAt(j - 1)) {
lcs.append(str1.charAt(i - 1)); lcs.append(str1.charAt(i - 1));
i--; i--;
j--; j--;
} else if (lcsMatrix[i - 1][j] > lcsMatrix[i][j - 1]) { } else if (lcsMatrix[i - 1][j] > lcsMatrix[i][j - 1]) {
// If the value above is larger, move up
i--; i--;
} else { } else {
// If the value to the left is larger, move left
j--; j--;
} }
} }
return lcs.reverse().toString();
}
public static void main(String[] args) { return lcs.reverse().toString(); // LCS built in reverse, so reverse it back
String str1 = "DSGSHSRGSRHTRD";
String str2 = "DATRGAGTSHS";
String lcs = getLCS(str1, str2);
// Print LCS
if (lcs != null) {
System.out.println("String 1: " + str1);
System.out.println("String 2: " + str2);
System.out.println("LCS: " + lcs);
System.out.println("LCS length: " + lcs.length());
}
} }
} }

View File

@ -0,0 +1,89 @@
package com.thealgorithms.dynamicprogramming;
import static org.junit.jupiter.api.Assertions.assertEquals;
import org.junit.jupiter.api.Test;
public class LongestCommonSubsequenceTest {
@Test
public void testLCSBasic() {
String str1 = "ABCBDAB";
String str2 = "BDCAB";
String expected = "BDAB"; // The longest common subsequence
String result = LongestCommonSubsequence.getLCS(str1, str2);
assertEquals(expected, result);
}
@Test
public void testLCSIdenticalStrings() {
String str1 = "AGGTAB";
String str2 = "AGGTAB";
String expected = "AGGTAB"; // LCS is the same as the strings
String result = LongestCommonSubsequence.getLCS(str1, str2);
assertEquals(expected, result);
}
@Test
public void testLCSNoCommonCharacters() {
String str1 = "ABC";
String str2 = "XYZ";
String expected = ""; // No common subsequence
String result = LongestCommonSubsequence.getLCS(str1, str2);
assertEquals(expected, result);
}
@Test
public void testLCSWithEmptyString() {
String str1 = "";
String str2 = "XYZ";
String expected = ""; // LCS with an empty string should be empty
String result = LongestCommonSubsequence.getLCS(str1, str2);
assertEquals(expected, result);
}
@Test
public void testLCSWithBothEmptyStrings() {
String str1 = "";
String str2 = "";
String expected = ""; // LCS with both strings empty should be empty
String result = LongestCommonSubsequence.getLCS(str1, str2);
assertEquals(expected, result);
}
@Test
public void testLCSWithNullFirstString() {
String str1 = null;
String str2 = "XYZ";
String expected = null; // Should return null if first string is null
String result = LongestCommonSubsequence.getLCS(str1, str2);
assertEquals(expected, result);
}
@Test
public void testLCSWithNullSecondString() {
String str1 = "ABC";
String str2 = null;
String expected = null; // Should return null if second string is null
String result = LongestCommonSubsequence.getLCS(str1, str2);
assertEquals(expected, result);
}
@Test
public void testLCSWithNullBothStrings() {
String str1 = null;
String str2 = null;
String expected = null; // Should return null if both strings are null
String result = LongestCommonSubsequence.getLCS(str1, str2);
assertEquals(expected, result);
}
@Test
public void testLCSWithLongerStringContainingCommonSubsequence() {
String str1 = "ABCDEF";
String str2 = "AEBDF";
String expected = "ABDF"; // Common subsequence is "ABDF"
String result = LongestCommonSubsequence.getLCS(str1, str2);
assertEquals(expected, result);
}
}