style: include NAB_NEEDLESS_BOOLEAN_CONSTANT_CONVERSION (#5149)

* style: use `assertFalse` and `assertTrue`

* style: include `NAB_NEEDLESS_BOOLEAN_CONSTANT_CONVERSION`
This commit is contained in:
Piotr Idzik
2024-05-08 19:11:46 +02:00
committed by GitHub
parent d3bb691f59
commit d2ddec55e5
11 changed files with 47 additions and 43 deletions

View File

@ -126,9 +126,6 @@
<Match> <Match>
<Bug pattern="OCP_OVERLY_CONCRETE_PARAMETER" /> <Bug pattern="OCP_OVERLY_CONCRETE_PARAMETER" />
</Match> </Match>
<Match>
<Bug pattern="NAB_NEEDLESS_BOOLEAN_CONSTANT_CONVERSION" />
</Match>
<Match> <Match>
<Bug pattern="LSC_LITERAL_STRING_COMPARISON" /> <Bug pattern="LSC_LITERAL_STRING_COMPARISON" />
</Match> </Match>

View File

@ -26,10 +26,10 @@ public abstract class CompositeLFSR implements BaseLFSR {
private boolean getMajorityBit() { private boolean getMajorityBit() {
Map<Boolean, Integer> bitCount = new TreeMap<>(); Map<Boolean, Integer> bitCount = new TreeMap<>();
bitCount.put(false, 0); bitCount.put(Boolean.FALSE, 0);
bitCount.put(true, 0); bitCount.put(Boolean.TRUE, 0);
registers.forEach(lfsr -> bitCount.put(lfsr.getClockBit(), bitCount.get(lfsr.getClockBit()) + 1)); registers.forEach(lfsr -> bitCount.put(lfsr.getClockBit(), bitCount.get(lfsr.getClockBit()) + 1));
return bitCount.get(false) <= bitCount.get(true); return bitCount.get(Boolean.FALSE) <= bitCount.get(Boolean.TRUE);
} }
} }

View File

@ -34,7 +34,7 @@ class dijkstras {
for (int i = 0; i < k; i++) { for (int i = 0; i < k; i++) {
dist[i] = Integer.MAX_VALUE; dist[i] = Integer.MAX_VALUE;
Set[i] = false; Set[i] = Boolean.FALSE;
} }
dist[src] = 0; dist[src] = 0;
@ -42,7 +42,7 @@ class dijkstras {
for (int c = 0; c < k - 1; c++) { for (int c = 0; c < k - 1; c++) {
int u = minDist(dist, Set); int u = minDist(dist, Set);
Set[u] = true; Set[u] = Boolean.TRUE;
for (int v = 0; v < k; v++) { for (int v = 0; v < k; v++) {
if (!Set[v] && graph[u][v] != 0 && dist[u] != Integer.MAX_VALUE && dist[u] + graph[u][v] < dist[v]) { if (!Set[v] && graph[u][v] != 0 && dist[u] != Integer.MAX_VALUE && dist[u] + graph[u][v] < dist[v]) {

View File

@ -50,7 +50,7 @@ class PrimMST {
// Initialize all keys as INFINITE // Initialize all keys as INFINITE
for (int i = 0; i < V; i++) { for (int i = 0; i < V; i++) {
key[i] = Integer.MAX_VALUE; key[i] = Integer.MAX_VALUE;
mstSet[i] = false; mstSet[i] = Boolean.FALSE;
} }
// Always include first 1st vertex in MST. // Always include first 1st vertex in MST.
@ -65,7 +65,7 @@ class PrimMST {
int u = minKey(key, mstSet); int u = minKey(key, mstSet);
// Add the picked vertex to the MST Set // Add the picked vertex to the MST Set
mstSet[u] = true; mstSet[u] = Boolean.TRUE;
// Update key value and parent index of the adjacent // Update key value and parent index of the adjacent
// vertices of the picked vertex. Consider only those // vertices of the picked vertex. Consider only those

View File

@ -31,7 +31,7 @@ public final class JobSequencing {
// Function to print the job sequence // Function to print the job sequence
public static String findJobSequence(ArrayList<Job> jobs, int size) { public static String findJobSequence(ArrayList<Job> jobs, int size) {
Boolean[] slots = new Boolean[size]; Boolean[] slots = new Boolean[size];
Arrays.fill(slots, false); Arrays.fill(slots, Boolean.FALSE);
int[] result = new int[size]; int[] result = new int[size];
@ -40,7 +40,7 @@ public final class JobSequencing {
for (int j = jobs.get(i).deadline - 1; j >= 0; j--) { for (int j = jobs.get(i).deadline - 1; j >= 0; j--) {
if (!slots[j]) { if (!slots[j]) {
result[j] = i; result[j] = i;
slots[j] = true; slots[j] = Boolean.TRUE;
break; break;
} }
} }

View File

@ -25,7 +25,7 @@ public class CircleSort implements SortAlgorithm {
boolean swapped = false; boolean swapped = false;
if (left == right) { if (left == right) {
return false; return Boolean.FALSE;
} }
int low = left; int low = left;

View File

@ -1,14 +1,17 @@
package com.thealgorithms.bitmanipulation; package com.thealgorithms.bitmanipulation;
import static org.junit.jupiter.api.Assertions.assertEquals; import static org.junit.jupiter.api.Assertions.assertFalse;
import static org.junit.jupiter.api.Assertions.assertTrue;
import org.junit.jupiter.api.Test; import org.junit.jupiter.api.Test;
class IsEvenTest { class IsEvenTest {
@Test @Test
void testIsEven() { void testIsEven() {
assertEquals(true, IsEven.isEven(2)); assertTrue(IsEven.isEven(0));
assertEquals(true, IsEven.isEven(-12)); assertTrue(IsEven.isEven(2));
assertEquals(false, IsEven.isEven(21)); assertTrue(IsEven.isEven(-12));
assertFalse(IsEven.isEven(21));
assertFalse(IsEven.isEven(-1));
} }
} }

View File

@ -1,6 +1,7 @@
package com.thealgorithms.dynamicprogramming; package com.thealgorithms.dynamicprogramming;
import static org.junit.jupiter.api.Assertions.assertEquals; import static org.junit.jupiter.api.Assertions.assertFalse;
import static org.junit.jupiter.api.Assertions.assertTrue;
import org.junit.jupiter.api.Test; import org.junit.jupiter.api.Test;
@ -8,10 +9,10 @@ class SumOfSubsetTest {
@Test @Test
void basicCheck() { void basicCheck() {
assertEquals(false, SumOfSubset.subsetSum(new int[] {1, 2, 7, 10, 9}, 4, 14)); assertFalse(SumOfSubset.subsetSum(new int[] {1, 2, 7, 10, 9}, 4, 14));
assertEquals(false, SumOfSubset.subsetSum(new int[] {2, 15, 1, 6, 7}, 4, 4)); assertFalse(SumOfSubset.subsetSum(new int[] {2, 15, 1, 6, 7}, 4, 4));
assertEquals(true, SumOfSubset.subsetSum(new int[] {7, 3, 2, 5, 8}, 4, 14)); assertTrue(SumOfSubset.subsetSum(new int[] {7, 3, 2, 5, 8}, 4, 14));
assertEquals(true, SumOfSubset.subsetSum(new int[] {4, 3, 2, 1}, 3, 5)); assertTrue(SumOfSubset.subsetSum(new int[] {4, 3, 2, 1}, 3, 5));
assertEquals(true, SumOfSubset.subsetSum(new int[] {1, 7, 2, 9, 10}, 4, 13)); assertTrue(SumOfSubset.subsetSum(new int[] {1, 7, 2, 9, 10}, 4, 13));
} }
} }

View File

@ -1,6 +1,7 @@
package com.thealgorithms.maths; package com.thealgorithms.maths;
import static org.junit.jupiter.api.Assertions.assertEquals; import static org.junit.jupiter.api.Assertions.assertFalse;
import static org.junit.jupiter.api.Assertions.assertTrue;
import org.junit.jupiter.api.Test; import org.junit.jupiter.api.Test;
@ -8,14 +9,14 @@ public class PythagoreanTripleTest {
@Test @Test
public void Testpythagoreantriple() { public void Testpythagoreantriple() {
assertEquals(true, PythagoreanTriple.isPythagTriple(3, 4, 5)); assertTrue(PythagoreanTriple.isPythagTriple(3, 4, 5));
assertEquals(true, PythagoreanTriple.isPythagTriple(6, 8, 10)); assertTrue(PythagoreanTriple.isPythagTriple(6, 8, 10));
assertEquals(true, PythagoreanTriple.isPythagTriple(9, 12, 15)); assertTrue(PythagoreanTriple.isPythagTriple(9, 12, 15));
assertEquals(true, PythagoreanTriple.isPythagTriple(12, 16, 20)); assertTrue(PythagoreanTriple.isPythagTriple(12, 16, 20));
assertEquals(true, PythagoreanTriple.isPythagTriple(15, 20, 25)); assertTrue(PythagoreanTriple.isPythagTriple(15, 20, 25));
assertEquals(true, PythagoreanTriple.isPythagTriple(18, 24, 30)); assertTrue(PythagoreanTriple.isPythagTriple(18, 24, 30));
assertEquals(false, PythagoreanTriple.isPythagTriple(5, 20, 30)); assertFalse(PythagoreanTriple.isPythagTriple(5, 20, 30));
assertEquals(false, PythagoreanTriple.isPythagTriple(6, 8, 100)); assertFalse(PythagoreanTriple.isPythagTriple(6, 8, 100));
assertEquals(false, PythagoreanTriple.isPythagTriple(-2, -2, 2)); assertFalse(PythagoreanTriple.isPythagTriple(-2, -2, 2));
} }
} }

View File

@ -1,6 +1,7 @@
package com.thealgorithms.others; package com.thealgorithms.others;
import static org.junit.jupiter.api.Assertions.assertEquals; import static org.junit.jupiter.api.Assertions.assertFalse;
import static org.junit.jupiter.api.Assertions.assertTrue;
import org.junit.jupiter.api.Test; import org.junit.jupiter.api.Test;
@ -10,34 +11,34 @@ public class TwoPointersTest {
void twoPointersFirstTestCase() { void twoPointersFirstTestCase() {
int[] arr = {2, 6, 9, 22, 121}; int[] arr = {2, 6, 9, 22, 121};
int key = 28; int key = 28;
assertEquals(true, TwoPointers.isPairedSum(arr, key)); assertTrue(TwoPointers.isPairedSum(arr, key));
} }
@Test @Test
void twoPointersSecondTestCase() { void twoPointersSecondTestCase() {
int[] arr = {-1, -12, 12, 0, 8}; int[] arr = {-1, -12, 12, 0, 8};
int key = 0; int key = 0;
assertEquals(true, TwoPointers.isPairedSum(arr, key)); assertTrue(TwoPointers.isPairedSum(arr, key));
} }
@Test @Test
void twoPointersThirdTestCase() { void twoPointersThirdTestCase() {
int[] arr = {12, 35, 12, 152, 0}; int[] arr = {12, 35, 12, 152, 0};
int key = 13; int key = 13;
assertEquals(false, TwoPointers.isPairedSum(arr, key)); assertFalse(TwoPointers.isPairedSum(arr, key));
} }
@Test @Test
void twoPointersFourthTestCase() { void twoPointersFourthTestCase() {
int[] arr = {-2, 5, -1, 52, 31}; int[] arr = {-2, 5, -1, 52, 31};
int key = -3; int key = -3;
assertEquals(true, TwoPointers.isPairedSum(arr, key)); assertTrue(TwoPointers.isPairedSum(arr, key));
} }
@Test @Test
void twoPointersFiftiethTestCase() { void twoPointersFiftiethTestCase() {
int[] arr = {25, 1, 0, 61, 21}; int[] arr = {25, 1, 0, 61, 21};
int key = 12; int key = 12;
assertEquals(false, TwoPointers.isPairedSum(arr, key)); assertFalse(TwoPointers.isPairedSum(arr, key));
} }
} }

View File

@ -1,6 +1,7 @@
package com.thealgorithms.strings; package com.thealgorithms.strings;
import static org.junit.jupiter.api.Assertions.assertEquals; import static org.junit.jupiter.api.Assertions.assertFalse;
import static org.junit.jupiter.api.Assertions.assertTrue;
import org.junit.jupiter.api.Test; import org.junit.jupiter.api.Test;
@ -8,16 +9,16 @@ public class ValidParenthesesTest {
@Test @Test
void testOne() { void testOne() {
assertEquals(true, ValidParentheses.isValid("()")); assertTrue(ValidParentheses.isValid("()"));
} }
@Test @Test
void testTwo() { void testTwo() {
assertEquals(true, ValidParentheses.isValid("()[]{}")); assertTrue(ValidParentheses.isValid("()[]{}"));
} }
@Test @Test
void testThree() { void testThree() {
assertEquals(false, ValidParentheses.isValid("(]")); assertFalse(ValidParentheses.isValid("(]"));
} }
} }