algorithm/Java
1
0
Fork 0
mirror of https://github.com/TheAlgorithms/Java.git synced 2025-07-25 05:22:39 +08:00
Code Issues Packages Projects Releases Wiki Activity

style: enable ParameterName in CheckStyle. (#5196)

Browse Source 
* Enabled: ParameterName in CheckStyle.

* Refactored to fix  bug caused by selfAssignment of variables in VectorCrossproduct class
This commit is contained in:
Godwill Christopher
2024-05-31 14:01:11 -06:00
committed by GitHub
parent 2568b96784
commit c42b1c940c
23 changed files with 139 additions and 139 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
src/main/java/com/thealgorithms/conversions/RomanToInteger.java
View File

@ -24,31 +24,31 @@ public final class RomanToInteger {
/**
* This function convert Roman number into Integer
*
* @param A Roman number string
* @param a Roman number string
* @return integer
*/
public static int romanToInt(String A) {
A = A.toUpperCase();
public static int romanToInt(String a) {
a = a.toUpperCase();
char prev = ' ';
int sum = 0;
int newPrev = 0;
for (int i = A.length() - 1; i >= 0; i--) {
char c = A.charAt(i);
for (int i = a.length() - 1; i >= 0; i--) {
char c = a.charAt(i);
if (prev != ' ') {
// checking current Number greater then previous or not
// checking current Number greater than previous or not
newPrev = ROMAN_TO_INT.get(prev) > newPrev ? ROMAN_TO_INT.get(prev) : newPrev;
}
int currentNum = ROMAN_TO_INT.get(c);
// if current number greater then prev max previous then add
// if current number greater than prev max previous then add
if (currentNum >= newPrev) {
sum += currentNum;
} else {
// subtract upcoming number until upcoming number not greater then prev max
// subtract upcoming number until upcoming number not greater than prev max
sum -= currentNum;
}