From bd785dea4dadc2b2967d174cf3afebe88a699fb8 Mon Sep 17 00:00:00 2001
From: "p@ren" <83308376+paren-thesis@users.noreply.github.com>
Date: Sun, 12 Jan 2025 11:29:27 +0000
Subject: [PATCH] Refactor and enhance the 'Upper' class (#6118)

---
 .../java/com/thealgorithms/strings/Upper.java    | 16 ++++++++++------
 1 file changed, 10 insertions(+), 6 deletions(-)

diff --git a/src/main/java/com/thealgorithms/strings/Upper.java b/src/main/java/com/thealgorithms/strings/Upper.java
index fa9a40841..5e248cb6e 100644
--- a/src/main/java/com/thealgorithms/strings/Upper.java
+++ b/src/main/java/com/thealgorithms/strings/Upper.java
@@ -21,15 +21,19 @@ public final class Upper {
      * @return the {@code String}, converted to uppercase.
      */
     public static String toUpperCase(String s) {
-        if (s == null || s.isEmpty()) {
+        if (s == null) {
+            throw new IllegalArgumentException("Input string connot be null");
+        }
+        if (s.isEmpty()) {
             return s;
         }
-        char[] values = s.toCharArray();
-        for (int i = 0; i < values.length; ++i) {
-            if (Character.isLetter(values[i]) && Character.isLowerCase(values[i])) {
-                values[i] = Character.toUpperCase(values[i]);
+        StringBuilder result = new StringBuilder(s);
+        for (int i = 0; i < result.length(); ++i) {
+            char currentChar = result.charAt(i);
+            if (Character.isLetter(currentChar) && Character.isLowerCase(currentChar)) {
+                result.setCharAt(i, Character.toUpperCase(currentChar));
             }
         }
-        return new String(values);
+        return result.toString();
     }
 }