From b315b7d578c22be59baeb1289394f1a0442943ff Mon Sep 17 00:00:00 2001 From: Piotr Idzik <65706193+vil02@users.noreply.github.com> Date: Wed, 5 Jun 2024 20:52:12 +0200 Subject: [PATCH] style: include `WMI_WRONG_MAP_ITERATOR` (#5206) --- spotbugs-exclude.xml | 3 --- .../datastructures/graphs/KahnsAlgorithm.java | 19 +++---------------- .../hashmap/hashing/MajorityElement.java | 6 +++--- .../java/com/thealgorithms/maths/Mode.java | 6 +++--- 4 files changed, 9 insertions(+), 25 deletions(-) diff --git a/spotbugs-exclude.xml b/spotbugs-exclude.xml index f621c84dd..ffafa51e7 100644 --- a/spotbugs-exclude.xml +++ b/spotbugs-exclude.xml @@ -68,9 +68,6 @@ - - - diff --git a/src/main/java/com/thealgorithms/datastructures/graphs/KahnsAlgorithm.java b/src/main/java/com/thealgorithms/datastructures/graphs/KahnsAlgorithm.java index 145071890..be83ea32f 100644 --- a/src/main/java/com/thealgorithms/datastructures/graphs/KahnsAlgorithm.java +++ b/src/main/java/com/thealgorithms/datastructures/graphs/KahnsAlgorithm.java @@ -54,19 +54,6 @@ class AdjacencyList> { Set getVertices() { return adj.keySet(); } - - /** - * Prints the adjacency list - */ - void printGraph() { - for (E vertex : adj.keySet()) { - System.out.print(vertex + " : "); - for (E adjacent : adj.get(vertex)) { - System.out.print(adjacent + " "); - } - System.out.println(); - } - } } class TopologicalSort> { @@ -104,9 +91,9 @@ class TopologicalSort> { calculateInDegree(); Queue q = new LinkedList(); - for (E vertex : inDegree.keySet()) { - if (inDegree.get(vertex) == 0) { - q.add(vertex); + for (final var entry : inDegree.entrySet()) { + if (entry.getValue() == 0) { + q.add(entry.getKey()); } } diff --git a/src/main/java/com/thealgorithms/datastructures/hashmap/hashing/MajorityElement.java b/src/main/java/com/thealgorithms/datastructures/hashmap/hashing/MajorityElement.java index bfa5759a4..56d2b0ef9 100644 --- a/src/main/java/com/thealgorithms/datastructures/hashmap/hashing/MajorityElement.java +++ b/src/main/java/com/thealgorithms/datastructures/hashmap/hashing/MajorityElement.java @@ -27,9 +27,9 @@ public final class MajorityElement { } } List majorityElements = new ArrayList<>(); - for (int key : numToCount.keySet()) { - if (numToCount.get(key) >= n / 2) { - majorityElements.add(key); + for (final var entry : numToCount.entrySet()) { + if (entry.getValue() >= n / 2) { + majorityElements.add(entry.getKey()); } } return majorityElements; diff --git a/src/main/java/com/thealgorithms/maths/Mode.java b/src/main/java/com/thealgorithms/maths/Mode.java index a92f404c6..f0b747cf0 100644 --- a/src/main/java/com/thealgorithms/maths/Mode.java +++ b/src/main/java/com/thealgorithms/maths/Mode.java @@ -38,9 +38,9 @@ public final class Mode { int max = Collections.max(count.values()); ArrayList modes = new ArrayList<>(); - for (int num : count.keySet()) { - if (count.get(num) == max) { - modes.add(num); + for (final var entry : count.entrySet()) { + if (entry.getValue() == max) { + modes.add(entry.getKey()); } } return modes.stream().mapToInt(n -> n).toArray();