From f8605b957a7d5ec4010fc9db6434ff691a0eb5f5 Mon Sep 17 00:00:00 2001 From: Marcos <33052423+markettes@users.noreply.github.com> Date: Thu, 11 Apr 2019 12:20:53 +0200 Subject: [PATCH 1/2] Efficiency Just two small things that in case the number was very big could be helpful. --- ciphers/Caesar.java | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/ciphers/Caesar.java b/ciphers/Caesar.java index 77cd5b9eb..a2c11db38 100644 --- a/ciphers/Caesar.java +++ b/ciphers/Caesar.java @@ -24,8 +24,8 @@ public class Caesar { public static String encode(String message, int shift) { String encoded = ""; - while (shift >= 26) { // 26 = number of latin letters - shift -= 26; + if (shift >= 26) { // 26 = number of latin letters + shift %= 26; } final int length = message.length(); @@ -62,8 +62,8 @@ public class Caesar { public static String decode(String encryptedMessage, int shift) { String decoded = ""; - while (shift >= 26) { // 26 = number of latin letters - shift -= 26; + if (shift >= 26) { // 26 = number of latin letters + shift %= 26; } final int length = encryptedMessage.length(); From ed99f58d9bf5a904cdc4f8f69cd26fd379c148c1 Mon Sep 17 00:00:00 2001 From: Marcos <33052423+markettes@users.noreply.github.com> Date: Thu, 2 May 2019 11:43:01 +0200 Subject: [PATCH 2/2] Now it's OK! --- ciphers/Caesar.java | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/ciphers/Caesar.java b/ciphers/Caesar.java index a2c11db38..06319f79d 100644 --- a/ciphers/Caesar.java +++ b/ciphers/Caesar.java @@ -24,9 +24,9 @@ public class Caesar { public static String encode(String message, int shift) { String encoded = ""; - if (shift >= 26) { // 26 = number of latin letters - shift %= 26; - } + + shift %= 26; + final int length = message.length(); for (int i = 0; i < length; i++) { @@ -62,9 +62,9 @@ public class Caesar { public static String decode(String encryptedMessage, int shift) { String decoded = ""; - if (shift >= 26) { // 26 = number of latin letters - shift %= 26; - } + + shift %= 26; + final int length = encryptedMessage.length(); for (int i = 0; i < length; i++) {