algorithm/Java
1
0
Fork 0
mirror of https://github.com/TheAlgorithms/Java.git synced 2025-07-12 06:37:03 +08:00
Code Issues Packages Projects Releases Wiki Activity

style: do not suppress serial (#5168)

Browse Source
This commit is contained in:
Piotr Idzik
2024-05-20 17:09:31 +02:00
committed by GitHub
parent 5ee98eeb48
commit 8466219685
3 changed files with 2 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
pom.xml
View File

@ -79,7 +79,6 @@
<arg>-Xlint:all</arg> <arg>-Xlint:all</arg>
<arg>-Xlint:-auxiliaryclass</arg> <arg>-Xlint:-auxiliaryclass</arg>
<arg>-Xlint:-rawtypes</arg> <arg>-Xlint:-rawtypes</arg>
<arg>-Xlint:-serial</arg>
<arg>-Xlint:-try</arg> <arg>-Xlint:-try</arg>
<arg>-Xlint:-unchecked</arg> <arg>-Xlint:-unchecked</arg>
<arg>-Xlint:-lossy-conversions</arg> <arg>-Xlint:-lossy-conversions</arg>

9
src/main/java/com/thealgorithms/sorts/TopologicalSort.java
View File

@ -73,13 +73,6 @@ public final class TopologicalSort {
} }
} }
static class BackEdgeException extends RuntimeException {
BackEdgeException(String backEdge) {
super("This graph contains a cycle. No linear ordering is possible. " + backEdge);
}
}
/* /*
* Depth First Search * Depth First Search
* *
@ -131,7 +124,7 @@ public final class TopologicalSort {
* *
* In many cases, we will not know u.f, but v.color denotes the type of edge * In many cases, we will not know u.f, but v.color denotes the type of edge
* */ * */
throw new BackEdgeException("Back edge: " + u.label + " -> " + label); throw new RuntimeException("This graph contains a cycle. No linear ordering is possible. Back edge: " + u.label + " -> " + label);
} }
}); });
u.color = Color.BLACK; u.color = Color.BLACK;

3
src/test/java/com/thealgorithms/sorts/TopologicalSortTest.java
View File

@ -4,7 +4,6 @@ import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.junit.jupiter.api.Assertions.assertIterableEquals; import static org.junit.jupiter.api.Assertions.assertIterableEquals;
import static org.junit.jupiter.api.Assertions.assertThrows; import static org.junit.jupiter.api.Assertions.assertThrows;
import com.thealgorithms.sorts.TopologicalSort.BackEdgeException;
import com.thealgorithms.sorts.TopologicalSort.Graph; import com.thealgorithms.sorts.TopologicalSort.Graph;
import java.util.LinkedList; import java.util.LinkedList;
import org.junit.jupiter.api.Test; import org.junit.jupiter.api.Test;
@ -55,7 +54,7 @@ class TopologicalSortTest {
graph.addEdge("6", "2"); graph.addEdge("6", "2");
graph.addEdge("7", ""); graph.addEdge("7", "");
graph.addEdge("8", ""); graph.addEdge("8", "");
Exception exception = assertThrows(BackEdgeException.class, () -> TopologicalSort.sort(graph)); Exception exception = assertThrows(RuntimeException.class, () -> TopologicalSort.sort(graph));
String expected = "This graph contains a cycle. No linear ordering is possible. " String expected = "This graph contains a cycle. No linear ordering is possible. "
+ "Back edge: 6 -> 2"; + "Back edge: 6 -> 2";
assertEquals(exception.getMessage(), expected); assertEquals(exception.getMessage(), expected);