diff --git a/Conversions/DecimalToBinary.java b/Conversions/DecimalToBinary.java index cd84486ae..ccd8c643f 100644 --- a/Conversions/DecimalToBinary.java +++ b/Conversions/DecimalToBinary.java @@ -35,6 +35,7 @@ class DecimalToBinary { n /= 2; } //converting decimal to binary System.out.println("\tBinary number: " + b); + input.close(); } /** diff --git a/Conversions/RomanToInteger.java b/Conversions/RomanToInteger.java index 4563ce4a4..0672a1464 100644 --- a/Conversions/RomanToInteger.java +++ b/Conversions/RomanToInteger.java @@ -4,7 +4,13 @@ import java.util.*; public class RomanToInteger { - private static Map map = new HashMap() {{ + private static Map map = new HashMap() { + /** + * + */ + private static final long serialVersionUID = 87605733047260530L; + + { put('I', 1); put('V', 5); put('X', 10); diff --git a/DataStructures/Buffers/CircularBuffer.java b/DataStructures/Buffers/CircularBuffer.java index ae047b815..a723f6930 100644 --- a/DataStructures/Buffers/CircularBuffer.java +++ b/DataStructures/Buffers/CircularBuffer.java @@ -26,12 +26,15 @@ public class CircularBuffer { return i % _buffer_size; } + public Character readOutChar() { Character result = null; + //if we have data to read if (_readable_data.get() > 0) { - result = new Character(_buffer[getTrueIndex(_read_index)]); + + result = Character.valueOf(_buffer[getTrueIndex(_read_index)]); _readable_data.decrementAndGet(); _read_index++; } diff --git a/DataStructures/Graphs/ConnectedComponent.java b/DataStructures/Graphs/ConnectedComponent.java index 7029a8d81..4582bfd44 100644 --- a/DataStructures/Graphs/ConnectedComponent.java +++ b/DataStructures/Graphs/ConnectedComponent.java @@ -108,7 +108,7 @@ class Graph> { public class ConnectedComponent { public static void main(String[] args) { - Graph graphChars = new Graph(); + Graph graphChars = new Graph<>(); // Graph 1 graphChars.addEdge('a', 'b'); @@ -123,7 +123,7 @@ public class ConnectedComponent { graphChars.addEdge('w', 'w'); - Graph graphInts = new Graph(); + Graph graphInts = new Graph<>(); // Graph 2 graphInts.addEdge(1, 2); diff --git a/DataStructures/Graphs/Cycles.java b/DataStructures/Graphs/Cycles.java index b6fd8b4c5..0b0ae22d7 100644 --- a/DataStructures/Graphs/Cycles.java +++ b/DataStructures/Graphs/Cycles.java @@ -10,7 +10,7 @@ class Cycle { private int[][] adjacencyMatrix; private boolean[] visited; ArrayList> cycles = new ArrayList>(); - private boolean[] finalCycles; + public Cycle() { Scanner in = new Scanner(System.in); @@ -34,6 +34,7 @@ class Cycle { end = in.nextInt(); adjacencyMatrix[start][end] = 1; } + in.close(); } diff --git a/DataStructures/Graphs/PrimMST.java b/DataStructures/Graphs/PrimMST.java index 32487fedd..474893775 100644 --- a/DataStructures/Graphs/PrimMST.java +++ b/DataStructures/Graphs/PrimMST.java @@ -1,7 +1,5 @@ package DataStructures.Graphs; -import java.lang.*; - /** * A Java program for Prim's Minimum Spanning Tree (MST) algorithm. * adjacency matrix representation of the graph diff --git a/DataStructures/HashMap/Hashing/LinkedList.java b/DataStructures/HashMap/Hashing/LinkedList.java index 8c4ec0f73..4953551f7 100644 --- a/DataStructures/HashMap/Hashing/LinkedList.java +++ b/DataStructures/HashMap/Hashing/LinkedList.java @@ -12,7 +12,6 @@ class LinkedList { public void insert(int data) { - Node temp = Head; Node newnode = new Node(data); size++; diff --git a/DataStructures/HashMap/Hashing/Main.java b/DataStructures/HashMap/Hashing/Main.java index 340f0760b..9611b6025 100644 --- a/DataStructures/HashMap/Hashing/Main.java +++ b/DataStructures/HashMap/Hashing/Main.java @@ -8,6 +8,7 @@ public class Main { int choice, key; HashMap h = new HashMap(7); + Scanner In = new Scanner(System.in); while (true) { System.out.println("Enter your Choice :"); @@ -15,9 +16,7 @@ public class Main { System.out.println("2. Delete Key"); System.out.println("3. Print Table"); System.out.println("4. Exit"); - - Scanner In = new Scanner(System.in); - + choice = In.nextInt(); switch (choice) { @@ -39,10 +38,11 @@ public class Main { break; } case 4: { + In.close(); return; } } - In.close(); + } } } \ No newline at end of file diff --git a/DataStructures/Lists/CursorLinkedList.java b/DataStructures/Lists/CursorLinkedList.java index 6e1caefc6..b12794fd1 100644 --- a/DataStructures/Lists/CursorLinkedList.java +++ b/DataStructures/Lists/CursorLinkedList.java @@ -4,6 +4,7 @@ import java.util.Objects; public class CursorLinkedList { + private static class Node { T element; @@ -13,13 +14,8 @@ public class CursorLinkedList { this.element = element; this.next = next; } - - boolean isEmpty() { - return element == null; - } } - private final int os; private int head; private final Node[] cursorSpace; @@ -27,6 +23,7 @@ public class CursorLinkedList { private final static int CURSOR_SPACE_SIZE = 100; + { // init at loading time cursorSpace = new Node[CURSOR_SPACE_SIZE]; diff --git a/DataStructures/Lists/SinglyLinkedList.java b/DataStructures/Lists/SinglyLinkedList.java index 1196851a3..5fda2f5f8 100644 --- a/DataStructures/Lists/SinglyLinkedList.java +++ b/DataStructures/Lists/SinglyLinkedList.java @@ -120,9 +120,9 @@ public class SinglyLinkedList { cur = cur.next; } - Node destroy = cur.next; + //Node destroy = cur.next; cur.next = cur.next.next; - destroy = null; // clear to let GC do its work + //destroy = null; // clear to let GC do its work size--; } diff --git a/DataStructures/Trees/RedBlackBST.java b/DataStructures/Trees/RedBlackBST.java index 197c96321..45501fd29 100644 --- a/DataStructures/Trees/RedBlackBST.java +++ b/DataStructures/Trees/RedBlackBST.java @@ -330,5 +330,6 @@ public class RedBlackBST { printTree(root); System.out.println("Pre order"); printTreepre(root); + scan.close(); } } \ No newline at end of file diff --git a/MinimizingLateness/MinimizingLateness.java b/MinimizingLateness/MinimizingLateness.java index 1438f6f3d..46e6fb4e0 100644 --- a/MinimizingLateness/MinimizingLateness.java +++ b/MinimizingLateness/MinimizingLateness.java @@ -26,6 +26,7 @@ public class MinimizingLateness { BufferedReader in = new BufferedReader(new FileReader("MinimizingLateness/lateness_data.txt")); String ch = in.readLine(); if (ch == null || ch.isEmpty()) { + in.close(); return; } int indexCount = Integer.parseInt(ch); diff --git a/Misc/heap_sort.java b/Misc/heap_sort.java index 5222be409..cf44b2b5a 100644 --- a/Misc/heap_sort.java +++ b/Misc/heap_sort.java @@ -57,8 +57,7 @@ public class heap_sort { // Driver program public static void main(String args[]) { int arr[] = {12, 11, 13, 5, 6, 7}; - int n = arr.length; - + heap_sort ob = new heap_sort(); ob.sort(arr); diff --git a/Sorts/MergeSort.java b/Sorts/MergeSort.java index 2b15a9ce0..f15e7af45 100644 --- a/Sorts/MergeSort.java +++ b/Sorts/MergeSort.java @@ -20,7 +20,7 @@ class MergeSort implements SortAlgorithm { * @return sorted array */ @Override - @SuppressWarnings("unchecked") + public > T[] sort(T[] unsorted) { doSort(unsorted, 0, unsorted.length - 1); return unsorted;