algorithm/Java
1
0
Fork 0
mirror of https://github.com/TheAlgorithms/Java.git synced 2026-02-04 04:23:32 +08:00
Code Issues Packages Projects Releases Wiki Activity

refactor: improve median calculator class design and readability (#6349)

Browse Source
This commit is contained in:
Oleksandr Klymenko
2025-07-07 13:29:10 +02:00
committed by GitHub
parent 8512f127ce
commit 2f5bc8c242
2 changed files with 93 additions and 69 deletions
Download Patch File Download Diff File Expand all files Collapse all files

80
src/test/java/com/thealgorithms/misc/MedianOfRunningArrayTest.java
View File

@@ -11,12 +11,12 @@ import org.junit.jupiter.api.Test;
*/
public class MedianOfRunningArrayTest {
private static final String EXCEPTION_MESSAGE = "Enter at least 1 element, Median of empty list is not defined!";
private static final String EXCEPTION_MESSAGE = "Median is undefined for an empty data set.";
@Test
public void testWhenInvalidInoutProvidedShouldThrowException() {
var stream = new MedianOfRunningArrayInteger();
IllegalArgumentException exception = assertThrows(IllegalArgumentException.class, () -> stream.median());
IllegalArgumentException exception = assertThrows(IllegalArgumentException.class, stream::getMedian);
assertEquals(exception.getMessage(), EXCEPTION_MESSAGE);
}
@@ -24,68 +24,68 @@ public class MedianOfRunningArrayTest {
public void testWithNegativeValues() {
var stream = new MedianOfRunningArrayInteger();
stream.insert(-1);
assertEquals(-1, stream.median());
assertEquals(-1, stream.getMedian());
stream.insert(-2);
assertEquals(-1, stream.median());
assertEquals(-1, stream.getMedian());
stream.insert(-3);
assertEquals(-2, stream.median());
assertEquals(-2, stream.getMedian());
}
@Test
public void testWithSingleValues() {
var stream = new MedianOfRunningArrayInteger();
stream.insert(-1);
assertEquals(-1, stream.median());
assertEquals(-1, stream.getMedian());
}
@Test
public void testWithRandomValues() {
var stream = new MedianOfRunningArrayInteger();
stream.insert(10);
assertEquals(10, stream.median());
assertEquals(10, stream.getMedian());
stream.insert(5);
assertEquals(7, stream.median());
assertEquals(7, stream.getMedian());
stream.insert(20);
assertEquals(10, stream.median());
assertEquals(10, stream.getMedian());
stream.insert(15);
assertEquals(12, stream.median());
assertEquals(12, stream.getMedian());
stream.insert(25);
assertEquals(15, stream.median());
assertEquals(15, stream.getMedian());
stream.insert(30);
assertEquals(17, stream.median());
assertEquals(17, stream.getMedian());
stream.insert(35);
assertEquals(20, stream.median());
assertEquals(20, stream.getMedian());
stream.insert(1);
assertEquals(17, stream.median());
assertEquals(17, stream.getMedian());
}
@Test
public void testWithNegativeAndPositiveValues() {
var stream = new MedianOfRunningArrayInteger();
stream.insert(-1);
assertEquals(-1, stream.median());
assertEquals(-1, stream.getMedian());
stream.insert(2);
assertEquals(0, stream.median());
assertEquals(0, stream.getMedian());
stream.insert(-3);
assertEquals(-1, stream.median());
assertEquals(-1, stream.getMedian());
}
@Test
public void testWithDuplicateValues() {
var stream = new MedianOfRunningArrayInteger();
stream.insert(-1);
assertEquals(-1, stream.median());
assertEquals(-1, stream.getMedian());
stream.insert(-1);
assertEquals(-1, stream.median());
assertEquals(-1, stream.getMedian());
stream.insert(-1);
assertEquals(-1, stream.median());
assertEquals(-1, stream.getMedian());
}
@Test
@@ -98,20 +98,20 @@ public class MedianOfRunningArrayTest {
stream.insert(20);
stream.insert(0);
stream.insert(50);
assertEquals(10, stream.median());
assertEquals(10, stream.getMedian());
}
@Test
public void testWithLargeValues() {
var stream = new MedianOfRunningArrayInteger();
stream.insert(1000000);
assertEquals(1000000, stream.median());
assertEquals(1000000, stream.getMedian());
stream.insert(12000);
assertEquals(506000, stream.median());
assertEquals(506000, stream.getMedian());
stream.insert(15000000);
assertEquals(1000000, stream.median());
assertEquals(1000000, stream.getMedian());
stream.insert(2300000);
assertEquals(1650000, stream.median());
assertEquals(1650000, stream.getMedian());
}
@Test
@@ -120,7 +120,7 @@ public class MedianOfRunningArrayTest {
for (int i = 1; i <= 1000; i++) {
stream.insert(i);
}
assertEquals(500, stream.median());
assertEquals(500, stream.getMedian());
}
@Test
@@ -129,7 +129,7 @@ public class MedianOfRunningArrayTest {
stream.insert(30);
stream.insert(20);
stream.insert(10);
assertEquals(20, stream.median());
assertEquals(20, stream.getMedian());
}
@Test
@@ -138,7 +138,7 @@ public class MedianOfRunningArrayTest {
stream.insert(10);
stream.insert(20);
stream.insert(30);
assertEquals(20, stream.median());
assertEquals(20, stream.getMedian());
}
@Test
@@ -147,7 +147,7 @@ public class MedianOfRunningArrayTest {
stream.insert(30);
stream.insert(10);
stream.insert(20);
assertEquals(20, stream.median());
assertEquals(20, stream.getMedian());
}
@Test
@@ -156,46 +156,46 @@ public class MedianOfRunningArrayTest {
stream.insert(20);
stream.insert(10);
stream.insert(30);
assertEquals(20, stream.median());
assertEquals(20, stream.getMedian());
}
@Test
public void testWithFloatValues() {
var stream = new MedianOfRunningArrayFloat();
stream.insert(20.0f);
assertEquals(20.0f, stream.median());
assertEquals(20.0f, stream.getMedian());
stream.insert(10.5f);
assertEquals(15.25f, stream.median());
assertEquals(15.25f, stream.getMedian());
stream.insert(30.0f);
assertEquals(20.0f, stream.median());
assertEquals(20.0f, stream.getMedian());
}
@Test
public void testWithByteValues() {
var stream = new MedianOfRunningArrayByte();
stream.insert((byte) 120);
assertEquals((byte) 120, stream.median());
assertEquals((byte) 120, stream.getMedian());
stream.insert((byte) -120);
assertEquals((byte) 0, stream.median());
assertEquals((byte) 0, stream.getMedian());
stream.insert((byte) 127);
assertEquals((byte) 120, stream.median());
assertEquals((byte) 120, stream.getMedian());
}
@Test
public void testWithLongValues() {
var stream = new MedianOfRunningArrayLong();
stream.insert(120000000L);
assertEquals(120000000L, stream.median());
assertEquals(120000000L, stream.getMedian());
stream.insert(92233720368547757L);
assertEquals(46116860244273878L, stream.median());
assertEquals(46116860244273878L, stream.getMedian());
}
@Test
public void testWithDoubleValues() {
var stream = new MedianOfRunningArrayDouble();
stream.insert(12345.67891);
assertEquals(12345.67891, stream.median());
assertEquals(12345.67891, stream.getMedian());
stream.insert(23456789.98);
assertEquals(11734567.83, stream.median(), .01);
assertEquals(11734567.83, stream.getMedian(), .01);
}
}