algorithm/Java
1
0
Fork 0
mirror of https://github.com/TheAlgorithms/Java.git synced 2025-07-07 09:45:04 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix: handle Null Dereference in RomanToInteger (#5461)

Browse Source
This commit is contained in:
Piotr Idzik
2024-09-23 10:33:55 +02:00
committed by GitHub
parent b849cbb602
commit 18f6f8c30a
3 changed files with 15 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
src/main/java/com/thealgorithms/conversions/RomanToInteger.java
View File

@ -19,6 +19,10 @@ public final class RomanToInteger {
}
};
private static int romanSymbolToInt(final char symbol) {
return ROMAN_TO_INT.computeIfAbsent(symbol, c -> { throw new IllegalArgumentException("Unknown Roman symbol: " + c); });
}
// Roman Number = Roman Numerals
/**
@ -39,10 +43,10 @@ public final class RomanToInteger {
if (prev != ' ') {
// checking current Number greater than previous or not
newPrev = ROMAN_TO_INT.get(prev) > newPrev ? ROMAN_TO_INT.get(prev) : newPrev;
newPrev = romanSymbolToInt(prev) > newPrev ? romanSymbolToInt(prev) : newPrev;
}
int currentNum = ROMAN_TO_INT.get(c);
int currentNum = romanSymbolToInt(c);
// if current number greater than prev max previous then add
if (currentNum >= newPrev) {
@ -57,9 +61,4 @@ public final class RomanToInteger {
return sum;
}
public static void main(String[] args) {
int sum = romanToInt("MDCCCIV");
System.out.println(sum);
}
}