algorithm/Java
1
0
Fork 0
mirror of https://github.com/TheAlgorithms/Java.git synced 2025-07-06 17:29:31 +08:00
Code Issues Packages Projects Releases Wiki Activity

#4367 Enhance Knapsack problem (#4368)

Browse Source 
* Enhance Knapsack problem

* Linter solved

* Linter solved

* Remove DynamicProgrammingKnapsack file, duplicate of Knapsack file

* Add null input testcase

* Linter resolved

* Updated meaningful test names

* Add check for negative weightCapacity

* Linter resolved

* Linter resolved

* Add check for non-positive weight

* Linter resolved

* fix: use proper formatting

* fix: use proper formatting

* fix: use proper formatting (I hope this will work now)

Sorry for the previous mess.

* Code review comments

* Code review comments

* Code review comments

* Code review comments

---------

Co-authored-by: Piotr Idzik <65706193+vil02@users.noreply.github.com>
This commit is contained in:
Manan Solanki
2023-09-20 01:23:53 +05:30
committed by GitHub
parent 26c2465328
commit 12b6c29243
3 changed files with 123 additions and 61 deletions
Download Patch File Download Diff File Expand all files Collapse all files

81
src/test/java/com/thealgorithms/dynamicprogramming/KnapsackTest.java Normal file
View File

@ -0,0 +1,81 @@
package com.thealgorithms.dynamicprogramming;
import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.junit.jupiter.api.Assertions.assertThrows;
import org.junit.jupiter.api.Test;
public class KnapsackTest {
@Test
public void testKnapSackBasic() {
int[] weights = {2, 3, 4, 5};
int[] values = {3, 4, 5, 6};
int weightCapacity = 5;
int expected = 7; // Maximum value should be 7 (items 1 and 4).
int result = Knapsack.knapSack(weightCapacity, weights, values);
assertEquals(expected, result);
}
@Test
public void testKnapSackEmpty() {
int[] weights = {};
int[] values = {};
int weightCapacity = 10;
int expected = 0; // With no items, the result should be 0.
int result = Knapsack.knapSack(weightCapacity, weights, values);
assertEquals(expected, result);
}
@Test
public void testKnapSackNoCapacity() {
int[] weights = {2, 3, 4};
int[] values = {3, 4, 5};
int weightCapacity = 0;
int expected = 0; // With no capacity, the result should be 0.
int result = Knapsack.knapSack(weightCapacity, weights, values);
assertEquals(expected, result);
}
@Test
public void testKnapSackMaxCapacity() {
int[] weights = {2, 3, 4, 5};
int[] values = {3, 4, 5, 6};
int weightCapacity = 10;
int expected = 13; // Maximum value should be 13 (items 1, 3, and 4).
int result = Knapsack.knapSack(weightCapacity, weights, values);
assertEquals(expected, result);
}
@Test
public void testKnapSackThrowsForInputsOfDifferentLength() {
int[] weights = {2, 3, 4};
int[] values = {3, 4, 5, 6}; // Different length values array.
int weightCapacity = 5;
assertThrows(IllegalArgumentException.class, () -> { Knapsack.knapSack(weightCapacity, weights, values); });
}
@Test
public void testKnapSackThrowsForNullInputs() {
int[] weights = {2, 3, 4};
int[] values = {3, 4, 6};
int weightCapacity = 5;
assertThrows(IllegalArgumentException.class, () -> { Knapsack.knapSack(weightCapacity, null, values); });
assertThrows(IllegalArgumentException.class, () -> { Knapsack.knapSack(weightCapacity, weights, null); });
}
@Test
public void testKnapSackThrowsForNegativeCapacity() {
int[] weights = {2, 3, 4, 5};
int[] values = {3, 4, 5, 6};
int weightCapacity = -5;
assertThrows(IllegalArgumentException.class, () -> { Knapsack.knapSack(weightCapacity, weights, values); });
}
@Test
public void testKnapSackThrowsForNegativeWeight() {
int[] weights = {2, 0, 4};
int[] values = {3, 4, 6};
int weightCapacity = 5;
assertThrows(IllegalArgumentException.class, () -> { Knapsack.knapSack(weightCapacity, weights, values); });
}
}